Database Group Triage for week ending 2023-11-10

About

This issue is used by groupdatabase to triage issues and make sure they get properly assigned and prioritized. Each week, a bot will look up the old issue, pick the next assignee in the list, and submit a new issue with a list of any issues that may need attention from the team.

Last week's issue

Process

  • Review any issues identified for triage
  • Review any issues with undefined types
  • Post any questions or pressing issues to the database group meeting doc
  • Post a comment on the database group status issue

    For triage this week there were 1 issues in need of triage, 3 issues without throughput labels, and 13 other database issues reviewed. <link to this issue>

Issues needing triage (Labeled databasetriage)

For each issue below:

  1. If the issue needs further investigation, spend up to 1 hour of investigating or fixing the issue.
  2. If the issue is a typebug, assign it one of severity1, severity2, severity3, or severity4
  3. Document any findings you make in a comment on the issue, and if the issue still needs additional work or refinement, consider looping in @alexives and @rogerwoo to help with scheduling and priority.
  4. If the issue is incomplete, labeled ~"workflow::scheduled", and will take more than an hour to fix, remove databasetriage
  • table design_user_mentions miss unique index for (design_id, note_id) on jihulab.com

Bugs needing Severity

For each issue below:

  1. For each typebug, spend up to 1 hour investigating or fixing the issue.
  2. Assign it one of severity1, severity2, severity3, or severity4
  3. Document any findings you make in a comment on the issue, and if the issue still needs additional work or refinement, consider looping in @alexives and @rogerwoo to help with scheduling and priority.
  • Investigate if we can drop users_forbidden_state_idx
  • Investigate if we can drop index_users_with_static_object_token
  • Investigate if we can drop index_users_require_two_factor_authentication_from_group_false
  • Investigate if we can drop index_users_on_updated_at
  • Investigate if we can drop index_users_on_require_two_factor_authentication_from_group
  • Investigate if we can drop index_users_on_id_and_last_activity_on_for_active_human_service
  • Investigate if we can drop index_users_on_group_view
  • Investigate if we can drop index_users_on_group_view
  • Investigate if we can drop index_users_on_email_trigram
  • Investigate if we can dropindex_users_on_email_domain_and_id
  • Investigate if we can drop index_users_on_accepted_term_id
  • Investigate if we can drop index_users_for_auditors
  • Investigate dropping index_uniq_projects_on_runners_token
  • Investigate dropping index_service_desk_enabled_projects_on_id_creator_id_created_at
  • Investigate dropping index_projects_on_repository_storage_ccold
  • Investigate dropping index_projects_on_repository_storage_ccnew
  • Investigate dropping index_projects_on_pending_delete
  • Investigate dropping index_projects_on_path_and_id
  • Investigate dropping index_projects_on_name_and_id_ccold
  • Investigate dropping index_projects_on_name_and_id_ccnew
  • Investigate dropping index_projects_on_mirror_last_successful_update_at
  • Investigate dropping index_projects_on_mirror_id_where_mirror_and_trigger_builds
  • Investigate dropping index_projects_on_mirror_creator_id_created_at
  • Investigate dropping index_projects_on_id_service_desk_enabled
  • Investigate dropping index_projects_on_ci_id
  • Investigate dropping index_projects_api_name_id_desc_ccold
  • Investigate dropping index_projects_api_name_id_desc_ccnew
  • Investigate dropping index_projects_api_created_at_id_desc
  • Investigate dropping index_on_projects_lower_path
  • Investigate dropping idx_projects_on_repository_storage_last_repository_update_ccnew
  • Investigate dropping idx_projects_id_created_at_disable_overriding_approvers_true
  • Investigate dropping idx_projects_id_created_at_disable_overriding_approvers_false

Issues with Undefined Type

For each issue below:

  1. Assess if the issue is appropriately assigned to groupdatabase, if not add the correct group label.
  2. Add the proper work type label, or if the issue is a request for support, redirect the user to our support resources with the following message:
    Hey @author. Based on the information given, this request for support is out of the scope of the issue tracker (which is for new bug reports and feature proposals). Unfortunately, I won't be able to help get it resolved. However, for support requests we have several resources that you can use to find help and support from the Community, including:
    * [Technical Support for Paid Tiers](https://about.gitlab.com/support/)
    * [Community Forum](https://forum.gitlab.com/)
    * [Reference Documents and Videos](https://about.gitlab.com/get-help/#references)
    
    Please refer to our [Support page](https://about.gitlab.com/support/) for more information.
    
    If you believe this was closed in error, please feel free to re-open the issue.
    
    /label ~"support request"
    /close
  3. If the issue needs further investigation, add databasetriage and spend up to 1 hour of investigating the issue.
  4. Document any findings you make in a comment on the issue, and if the issue still needs additional work or refinement, consider looping in @alexives and @rogerwoo to help with scheduling and priority.
  • [Feature flag] Enable invert_omniauth_args_merging
  • upgrade from 16.4.1 to 16.5.1 fails due to postgres key issue
  • Load balancer feature flag to force replicas to stay in load balancing despite significant lag

Recent issues labeled database

For each issue below:

  1. If the issue has no group label, consider if it should be addressed by groupdatabase and if so label it.
  2. If the issue has a group, and you think they may need assistance from us:
    • If the issue needs further investigation, add databasetriage and spend up to 1 hour of investigating the issue.
    • Document any findings you make in a comment on the issue, and if the issue still needs additional work or refinement, consider looping in @alexives and/or @rogerwoo
  • grouppipeline execution Ensure that all tables that reference ci_pipelines have partition_id column
  • grouppipeline execution Ensure that all tables that reference ci_stages have partition_id column
  • grouppipeline execution Update queries to include partition_id filter for ci_pipelines
  • grouppipeline execution Update queries to include partition_id filter for ci_pipeline_variables
  • grouppipeline execution Update queries to include partition_id filter for ci_stages
  • grouppipeline execution Update queries to include partition_id filter for ci_job_artifacts
  • groupsource code Extend ApprovalRules::CreateService to support group target
  • grouppipeline execution Ensure id uniqueness on ci_pipeline_varables
  • grouppipeline execution Ensure id uniqueness on p_ci_pipelines
  • grouppipeline execution Ensure id uniqueness for p_ci_stages
  • grouppipeline execution Ensure id uniqueness on p_ci_job_artifacts
  • grouppipeline execution Ensure that all tables that reference ci_job_artifacts have partition_id column
  • ~"group::not_owned" Upgrade to use PostgreSQL 14 by default

Recent mentions of @gitlab-org/database-team

For each mention below:

  1. If the item already has an adequate response, move on to the next
  2. If the mention is from someone looking to provide feedback on database review, and nobody has responded yet, set up a coffee chat with them and make a note in the thread that you did. Record feedback in the feedback issue.
  3. If you know how to respond to the comment, post a response
  4. If you don't know how, redirect with a specific mention to someone who may be able to respond
  • @renehernandez mentioned the team on Filter by package version in REST and Graphql APIs
  • @kwanyangu mentioned the team on Alternatives To Postgres DB
  • @krasio mentioned the team on Database Group Triage for week ending 2023-11-03

Customer Issue Hand-offs

For each issue below:

  1. If the item already has a back and forth, check in with the @krasio to see if what needs to be handed off
  2. Consider if it's right for our team and if not, ask the support rep to follow up with the correct team.
  3. If the item is right for our team, spend some time accessing it and trying to assist.
  4. If you need help, and the request seems pressing, ask in the team channel if there's someone who can help dig into it.
  • Stuck Migration: BackfillUuidConversionColumnInVulnerabilityOccurrences~"Help group::Database"
  • GitLab 15.11 DB migration workaround is not working for customer~"Help group::Database"
  • Migration fails with "migrations_paths setting for ci database must be db/ci_migrate"~"Help group::Database", severity3
  • The standby database is in a "running" state, but the standby leader itself is stuck in recovery~"Help group::Database", groupgeo

Review Recent Postgres Checkup

For each database:

  1. Are there new queries in the top queries (See: K003 Top-15 Queries by total_time) compared to a previous report?
  2. If there are new queries, Spend up to 30 minutes trying to understand their sources
  3. If there are new queries, file an issue and assign to the team that owns the query, or if unable to source, then the team that owns the table
  • Review recent Primary Checkup for new Top Queries
  • Review recent CI Checkup for new Top Queries

@alexives if @l.rosa isn't available this week, please reassign to @mattkasa cc @rogerwoo

Edited Nov 11, 2023 by Leonardo da Rosa
Assignee Loading
Time tracking Loading