Follow-up from "Remove ignored column from in_product_marketing_emails"
The following discussion from !135731 (merged) should be addressed:
-
@euko started a discussion: While I understand the background, I suggest we don't add the NULL constraints back in this migration and focus on removing the column only. It's easier to reason about what the migration does when we have an incident.
I don't have access to production, but accordingly to Database Lab there are 0 records with empty
track
orseries
in production. So I believe it's safe to addNOT NULL
back to these fields. Updated MR. WDYT?While I strongly recommend we go through the formal process for adding a NOT NULL constraint, we might try to add back the null constraints in a separate migration in 16.7 only if 1) we're absolutely sure the feature was only for SaaS and 2) no records have nulls.
-
An isolated migration is easier to revert.
-
I don't want to delay any deployment in this milestone since we're close to the cutoff.
-