Promote Vitaly Slobodin to FE maintainer
Intro
After becoming a FE maintainer for the Customers portal I also would like to become a FE maintainer for GitLab also.
I reviewed 63 merge requests in total. I treat the review process as a special process that requires an ability to think a step forward and an ability to understand the idea behind it. That's why I usually check out the MR locally and investigate it in action. As a Fulfillment team member, it is hard to be in sync with the main repo and its rules because we work on our separate application. This is the main reason why I go beyond my domain and our application and try to be active in all other aspects of the main repo, for instance:
- Helping with the Jestodus project (migrating Karma tests to Jest).
- Helping with linting all the things.
- Investigating, filing issues, and resolving the tech debt of the GL.com (fun fact: that does not include tech debt of our app).
- Improving our tools (eslint-plugin for example).
So here are two lists of MRs, as usual.
Links to Non-Trival MRs I've Reviewed
I didn't include the number of changes for each MR because this number is like a code coverage percent.
- Update ImportProjectsTable component
- Show storage graph with limits
- Add new matcher for interpolated strings
- Migrate from Vue event hub to Mitt (community contributon
- Geo Node Form in Vue - Selective Sync (Namespaces)
- Snippet edit form
- Group Activity - MRs Chart w/ Single Series: App skeleton
- Improve the suggest pipeline popover content alignment
- Improve UX for Group SAML Configuration page
Links to Non-Trivial MRs I've Written
This is a tricky part. As a team member who usually does not work on GL.COM it's a bit hard to list MRs here, but I tried to pick the most interesting.
- Notify EE admins as they approach the user limit in their subscription
- Send credentials with GraphQL fetch requests
- Documentation: Add Jest best practices
- [EE] Replace deprecated GlLoadingIcon sizes in EE
- Enable our Jest configuration. This MR was a result of introducing a Jest configuration in our ESLint configuration which was merged across our projects.
- I converted a lot of Karma specs to Jest. See this epic for the full list MRs.
- Add new layout for trial flow
- Sign in / sign up step for trialsgitlab-org/gitlab!15289 (merged))
- Frontend implementation for improved trial sign-up experience for GitLab.com (SaaS) users
If you want to check more MRs here is the previous MR about becoming a FE maintainer for the Customers portal.
@gitlab-org/maintainers/frontend please chime in below with your thoughts, and approve this MR if you agree.
Once This MR is Merged
-
Create an access request for maintainer access to gitlab-org
. -
Create an access request to be added to the [at]frontend-maintainers
slack group -
Let a maintainer add you to gitlab-org/maintainers/frontend
-
Announce it everywhere -
Keep reviewing, start merging 🤘 😎 🤘