Add Vitaly Slobodin as FE maintainer for Customers and License applications
Summary
When I joined the Fulfillment group (almost a year ago) our Customers application used classic Rails tools for serving the frontend. Due to requirements, we started the migration to webpacker gem and modern tools for developing and maintaining the frontend part of this project. I want to include the following important points that I made during this migration:
- Moved a lot of 3rd party JavaScript libraries from assets pipeline to NPM.
- Setup Jest testing infrastructure from 0 with common rules and approaches that we use on GL.com.
- Converted legacy 3rd party JavaScript (Zuora) to ES6 library for further adoption by
webpack. - Setup Sentry for tracking JavaScript errors.
- I also review updates from the Renovate bot of @gitlab/ui and @gitlab/svgs libraries. We still have legacy styles and we can't serve broken application so these updates require manual review.
- I often describe specific changes or add notes about changes in merge requests because Customers app doesn't have a FE maintainer still.
Another point that I would like to mention. Because we work on a separate application it's hard to gather required experience to become a maintainer so I try to go beyond my domain and participate in activities on the main application (because later we will adopt in our application).
Closes #5567 (closed)
Links to Non-Trival MRs I've Reviewed
- Migrate Plans page to Pajamas design system 614 -183
- Implement a Vue.js component for buying the CI Minutes Pack 486 -1 I suggested reducing the overall complexity of the Vue.js component by extracting logic into a separate file.
- Implement a Vue.js component for Sign in / Sign up 550 -39
- Add tables for displaying subscriptions 278 -0
- Integrate Zuora's iFrame to the Vue.js architecture 339 -176
Links to Non-Trivial MRs I've Written
NOTE: Some merge requests do not have numbers of changes specified in this list because we use VCR for mocking requests/responses to external services and merge requests may contain changes related to VCR cassettes. These changes make numbers really huge - 10365 -2553
- Enable auto-renew toggle for connected customers only
- Setup Webpack resolve aliases 64 -46
- Add Zuora iFrame test page 2475 -7
- Adopt @gitlab/eslint-plugin 52 -63
- Update application styles to match Pajamas design system 7 -20
- Update application styles to match Pajamas design system 25 -65
- Adopt @gitlab/stylelint-config 100 -429
- Introduce GitLab.com subscription plan upgrade page (and fix JS corner cases) 716 -159 My first merge request.
Other
If you want to check more merge requests I also have WIP issue for becoming a GitLab maintainer.
Once This MR is Merged
-
Create an access request for maintainer access to gitlab-org. -
Let a maintainer add you to gitlab-org/maintainers/frontend -
Announce it everywhere -
Keep reviewing, start merging 🤘 😎 🤘