Skip to content
Snippets Groups Projects

Add jwoodwardgl as a Backend Maintainer

Merged Sean Carroll requested to merge jwoodwardgl-backend-maintainer into master
1 unresolved thread

Manager Justification

It's hard to specify hard requirements for becoming a maintainer, which is why the documentation consists of flexible guidelines. Reviewers are encouraged to think of their eligibility for maintainership in the terms of "I could be ready at any time to be a maintainer as long as it is justified".

@jwoodwardgl has reviewed over 68 merged MRs and has authored over 100 merged MRs.

  • Passes on context when he has further domain knowledge on how to improve the MR or make the code easier 1, 2, 3, 4, 5, 6, 7, 8, 9
  • Cares about potential performance pitfalls 1, 2
  • Focuses on MR, documentation and code quality 1, 2, 3, 4, 5, 6, 7, 8, 9, 10
  • Unblocks stalled MR pipelines and supports other team members 1, 2, 3, 4, 5, 6, 7
  • Ensures metadata and MR communication is correct 1, 2, 3
  • Encourages code readability and re-use existing code when possible 1, 2
  • Identifies missing test cases and improves test case quality 1, 2, 3

Before Merging (Manager Tasks)

  • Close any relevant trainee maintainer issues with a comment indicating that this merge request is being created, as (they are no longer required to become a maintainer).
  • Mention the maintainers from the given specialty and ask them to provide feedback to the manager directly.
  • Leave this merge request open for 1 week, to give the maintainers time to provide feedback.
  • Ensure we have at least 2 approvals from existing maintainers.

Once This MR is Merged

  1. Join the #backend_maintainers Slack channel
  2. Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists.
  3. Let a maintainer add you to @gitlab-org/maintainers/rails-backend with Owner access level.
  4. Announce it everywhere
  5. Familiarize yourself with documentation for Merging a merge request
  6. Keep reviewing, start merging :metal: :sunglasses: :metal:

access-request

Relates to Team Member updates (gitlab-com/create-stage/source-code-be#48 - closed)

Edited by Joe Woodward

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Pavel Shutsin approved this merge request

    approved this merge request

  • Sashi Kumar Kumaresan approved this merge request

    approved this merge request

  • Brett Walker approved this merge request

    approved this merge request

  • Sean Carroll resolved all threads

    resolved all threads

  • Sean Carroll added 1 commit

    added 1 commit

    • d8096bc6 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Sean Carroll resolved all threads

    resolved all threads

  • Kerri Miller approved this merge request

    approved this merge request

  • Steve Abrams approved this merge request

    approved this merge request

  • Vitali Tatarintev approved this merge request

    approved this merge request

  • Ahmed Hemdan approved this merge request

    approved this merge request

  • Douglas Barbosa Alexandre approved this merge request

    approved this merge request

  • Andy Schoenen approved this merge request

    approved this merge request

  • Dylan Griffith approved this merge request

    approved this merge request

  • Ash McKenzie approved this merge request

    approved this merge request

  • charlie ablett approved this merge request

    approved this merge request

  • Abdul Wadood approved this merge request

    approved this merge request

  • Rajendra Kadam approved this merge request

    approved this merge request

  • Stan Hu approved this merge request

    approved this merge request

  • Imre Farkas approved this merge request

    approved this merge request

  • Alper Akgun approved this merge request

    approved this merge request

  • Dmitry Gruzd approved this merge request

    approved this merge request

  • Nicolas Dular approved this merge request

    approved this merge request

  • Vasilii Iakliushin approved this merge request

    approved this merge request

  • Manoj M J approved this merge request

    approved this merge request

  • Etienne Baqué approved this merge request

    approved this merge request

  • Vijay Hawoldar approved this merge request

    approved this merge request

  • Eugenia Grieff approved this merge request

    approved this merge request

  • Sean Carroll added 11143 commits

    added 11143 commits

    Compare with previous version

  • Aboobacker MK approved this merge request

    approved this merge request

  • Thong Kuah approved this merge request

    approved this merge request

  • Halil Coban approved this merge request

    approved this merge request

  • Sean Carroll marked the checklist item Leave this merge request open for 1 week, to give the maintainers time to provide feedback. as completed

    marked the checklist item Leave this merge request open for 1 week, to give the maintainers time to provide feedback. as completed

  • Sean Carroll marked the checklist item Ensure we have at least 2 approvals from existing maintainers. as completed

    marked the checklist item Ensure we have at least 2 approvals from existing maintainers. as completed

  • Sean Carroll approved this merge request

    approved this merge request

  • Sean Carroll started a merge train

    started a merge train

  • Sean Carroll marked the checklist item Announce it everywhere as completed

    marked the checklist item Announce it everywhere as completed

  • merged

  • Sean Carroll mentioned in commit 2f7f12c1

    mentioned in commit 2f7f12c1

  • Joe Woodward marked the checklist item Announce it everywhere as incomplete

    marked the checklist item Announce it everywhere as incomplete

  • Joe Woodward marked the checklist item Join the #backend_maintainers Slack channel as completed

    marked the checklist item Join the #backend_maintainers Slack channel as completed

  • Joe Woodward marked the checklist item Announce it everywhere as completed

    marked the checklist item Announce it everywhere as completed

  • Joe Woodward marked the checklist item Keep reviewing, start merging :metal: :sunglasses: :metal: as completed

    marked the checklist item Keep reviewing, start merging :metal: :sunglasses: :metal: as completed

  • Joe Woodward marked the checklist item Familiarize yourself with documentation for Merging a merge request as completed

    marked the checklist item Familiarize yourself with documentation for Merging a merge request as completed

  • Joe Woodward marked the checklist item Let a maintainer add you to @gitlab-org/maintainers/rails-backend with Owner access level. as completed

    marked the checklist item Let a maintainer add you to @gitlab-org/maintainers/rails-backend with Owner access level. as completed

  • Joe Woodward marked the checklist item Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists. as completed

    marked the checklist item Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists. as completed

  • Sean Carroll mentioned in merge request !128494 (merged)

    mentioned in merge request !128494 (merged)

  • Sean Carroll mentioned in merge request !122232 (merged)

    mentioned in merge request !122232 (merged)

  • Please register or sign in to reply
    Loading