Add jwoodwardgl as a Backend Maintainer
Manager Justification
It's hard to specify hard requirements for becoming a maintainer, which is why the documentation consists of flexible guidelines. Reviewers are encouraged to think of their eligibility for maintainership in the terms of "I could be ready at any time to be a maintainer as long as it is justified".
-
The MRs reviewed by the candidate consistently make it through maintainer review without significant additionally required changes. - LDAP duration metric should be milliseconds
- Refactor CSV exporter
- Efficiently fetch avatar from Gitaly
- Handle ambiguous reference error for
#find_branch
- Add ProjectStatistics to OpenAPI documentation
- Cleanup extract_mr_diff_deletions feature flag
- Fallback to start commit when merge base is missing
- Add a basic linter for CODEOWNERS file
- Update CODEOWNERS "Default Owner" REGEX
- Performance optimization for Projects API
- Update tree and blob resolvers to accept ref_type (gitlab-org/gitlab!122144 - merged)
-
The MRs authored by the candidate consistently make it through reviewer and maintainer review without significant required changes. - Introduce find_changed_paths with merge_commit_... (gitlab-org/gitlab!123501 - merged)
- Update Gitlab::Git::Repository#find_changed_pat... (gitlab-org/gitlab!123548 - merged)
- Do not diff paths changed in merge commits (gitlab-org/gitlab!123947 - merged)
- Remove `branch_rules` feature flag (gitlab-org/gitlab!123368 - merged)
- https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/3245+
- Add admin access option to protected branch/tag... (gitlab-org/gitlab!118661 - merged)
- Cleanup ProtectedRefAccess#check_access logic (gitlab-org/gitlab!119157 - merged)
- Remove admin override for ProtectedRef Access (gitlab-org/gitlab!118532 - merged)
- Reject invalid repository archive request formats (gitlab-org/gitlab!118996 - merged)
- Allow overriding of protected ref access level ... (gitlab-org/gitlab!118502 - merged)
@jwoodwardgl has reviewed over 68 merged MRs and has authored over 100 merged MRs.
- Passes on context when he has further domain knowledge on how to improve the MR or make the code easier 1, 2, 3, 4, 5, 6, 7, 8, 9
- Cares about potential performance pitfalls 1, 2
- Focuses on MR, documentation and code quality 1, 2, 3, 4, 5, 6, 7, 8, 9, 10
- Unblocks stalled MR pipelines and supports other team members 1, 2, 3, 4, 5, 6, 7
- Ensures metadata and MR communication is correct 1, 2, 3
- Encourages code readability and re-use existing code when possible 1, 2
- Identifies missing test cases and improves test case quality 1, 2, 3
Before Merging (Manager Tasks)
-
Close any relevant trainee maintainer issues with a comment indicating that this merge request is being created, as (they are no longer required to become a maintainer). -
Mention the maintainers from the given specialty and ask them to provide feedback to the manager directly. -
Leave this merge request open for 1 week, to give the maintainers time to provide feedback. -
Ensure we have at least 2 approvals from existing maintainers.
Once This MR is Merged
-
Join the #backend_maintainers
Slack channel -
Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists. -
Let a maintainer add you to @gitlab-org/maintainers/rails-backend
withOwner
access level. -
Announce it everywhere -
Familiarize yourself with documentation for Merging a merge request -
Keep reviewing, start merging
Relates to Team Member updates (gitlab-com/create-stage/source-code-be#48 - closed)
Merge request reports
Activity
added maintainer application label
assigned to @sean_carroll
@jwoodwardgl when merged this will make you a backend maintainer. Please link 5-6 complex MRs you have reviewed as the first step and we will discuss further in 1:1s.
assigned to @jwoodwardgl
added groupsource code label
unassigned @sean_carroll
assigned to @sean_carroll
marked the checklist item Close any relevant trainee maintainer issues with a comment indicating that this merge request is being created, as (they are no longer required to become a maintainer). as completed
@gitlab-org/maintainers/rails-backend Maintainers, please review this proposal to make @jwoodwardgl a backend maintainer of
gitlab-org/gitlab
project.- If you have blocking feedback adhering to the documentation please share it with me via Slack.
- If you are in agreement please approve or give a
on the MR
After 1 week, if there is no blocking feedback and at least 2 approvals, I will merge this MR.
- Resolved by Sean Carroll
added 11143 commits
-
d8096bc6...7f110bf4 - 11142 commits from branch
master
- 9fd53ecc - Make jwoodwardgl a BE maintainer
-
d8096bc6...7f110bf4 - 11142 commits from branch
@jwoodwardgl congratulations on becoming a Backend Maintainer!
Please follow the steps here
It has been announced in:
Edited by Sean Carroll
mentioned in commit 2f7f12c1
marked the checklist item Familiarize yourself with documentation for Merging a merge request as completed
mentioned in merge request !128494 (merged)
mentioned in merge request !122232 (merged)