Add missing encoding for tag related fields
What does this MR do and why?
Contributes to #411267 (closed)
Problem
The email of the user can have unsupported characters that can lead to 500 error.
Solution
Apply UTF-8 encoding for the data received from the Gitaly
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.0
added backend bugfunctional groupsource code labels
assigned to @vyaklushin
added typebug label
added devopscreate sectiondev labels
- Resolved by Felipe Cardozo
- A deleted user
added frontend label
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Tarun Vellishetty (
@tvellishetty
) (UTC+5.5, 3.5 hours ahead of@vyaklushin
)Ahmed Hemdan (
@ahmed.hemdan
) (UTC+2, same timezone as@vyaklushin
)frontend Laura Meckley (
@lmeckley
) (UTC-6, 8 hours behind@vyaklushin
)Frédéric Caplette (
@f_caplette
) (UTC-4, 6 hours behind@vyaklushin
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerSetting label(s) Category:Source Code Management based on groupsource code.
added Category:Source Code Management label
added 952 commits
-
18750d35...44865a2c - 951 commits from branch
master
- be83c439 - Add missing encoding for tag related fields
-
18750d35...44865a2c - 951 commits from branch
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Felipe Cardozo
Hi @jwoodwardgl!
Can you please review backend changes?
requested review from @jwoodwardgl
- Resolved by Joe Woodward
@jwoodwardgl
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
added 283 commits
-
be83c439...e8a51c9d - 281 commits from branch
master
- 348813ca - Add missing encoding for tag related fields
- 1dff1335 - Return Time object instead of Google::Protobuf::Timestamp
-
be83c439...e8a51c9d - 281 commits from branch
requested review from @felipe_artur
removed review request for @jwoodwardgl
- Resolved by Felipe Cardozo
enabled an automatic merge when the pipeline for 2a274b34 succeeds
mentioned in commit edcbc110
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)
mentioned in merge request gitlab-com/www-gitlab-com!122228 (merged)