Skip to content
Snippets Groups Projects

Add missing encoding for tag related fields

Merged Vasilii Iakliushin requested to merge 411267_add_encoding_for_tags into master
All threads resolved!

What does this MR do and why?

Contributes to #411267 (closed)

Problem

The email of the user can have unsupported characters that can lead to 500 error.

Solution

Apply UTF-8 encoding for the data received from the Gitaly

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Vasilii Iakliushin

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • A deleted user added frontend label

    added frontend label

  • Contributor

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend Tarun Vellishetty current availability (@tvellishetty) (UTC+5.5, 3.5 hours ahead of @vyaklushin) Ahmed Hemdan current availability (@ahmed.hemdan) (UTC+2, same timezone as @vyaklushin)
    frontend Laura Meckley current availability (@lmeckley) (UTC-6, 8 hours behind @vyaklushin) Frédéric Caplette current availability (@f_caplette) (UTC-4, 6 hours behind @vyaklushin)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • added 1 commit

    • 18750d35 - Add missing encoding for tag related fields

    Compare with previous version

  • Vasilii Iakliushin added 952 commits

    added 952 commits

    Compare with previous version

  • Vasilii Iakliushin marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • requested review from @jwoodwardgl

  • Joe Woodward
  • Joe Woodward approved this merge request

    approved this merge request

  • :wave: @jwoodwardgl, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Vasilii Iakliushin added 283 commits

    added 283 commits

    • be83c439...e8a51c9d - 281 commits from branch master
    • 348813ca - Add missing encoding for tag related fields
    • 1dff1335 - Return Time object instead of Google::Protobuf::Timestamp

    Compare with previous version

  • requested review from @felipe_artur

  • Joe Woodward removed review request for @jwoodwardgl

    removed review request for @jwoodwardgl

  • Felipe Cardozo
  • Felipe Cardozo approved this merge request

    approved this merge request

  • Felipe Cardozo resolved all threads

    resolved all threads

  • Felipe Cardozo enabled an automatic merge when the pipeline for 2a274b34 succeeds

    enabled an automatic merge when the pipeline for 2a274b34 succeeds

  • merged

  • Felipe Cardozo mentioned in commit edcbc110

    mentioned in commit edcbc110

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading