Skip to content

Add Steve Abrams as backend maintainer

Steve Abrams requested to merge sabrams-master-patch-24176 into master

Trainee maintainer issue: #13277 (closed)

🗺 Overview

I've worked at GitLab as a backend engineer in ~"group::package" since May 2019.

📰 Examples of reviews

📈 Things to improve

I have been feeling more and more confident with my reviews and in unfamiliar areas of code. I believe taking on the responsibility of maintainership will help me continue to expand my expertise and further push myself to trust my judgement and grow my confidence.

Self-assessed areas to improve

  • Manage my time better in reviews by asking questions when I'm uncertain about what something I don't understand is doing rather than spending a long time working it out myself. In other words, make my reviews more collaborative.
  • Continue to learn about more domains in the app that I have not had as much exposure to.
  • Secure code guidelines. I feel confident in my general awareness of security, but there are so many little things in this topic, there is always more to learn and look out for.

Self-assessed strengths

  • Awareness of when I'm unsure about something and need to ask for help.
  • Positive and engaging reviews.
  • Domain expertise in all package stage features and also all areas of authentication (API Guard, controllers, Gitlab::Auth for Git and JWT related features) and authorization (declarative policy framework).
  • Focus on development and performance guidelines as well as educating everyone involved.

@gitlab-org/maintainers/rails-backend please chime in below with your thoughts, and approve this MR if you agree.

Developer checklist :check

  • Before this MR is merged
    • Mention @gitlab-org/maintainers/rails-backend, if not done (this issue template should do this automatically)
    • Assign this issue to your manager
  • After this MR is merged
    • Request a maintainer from the #backend_maintainers Slack channel to add you as an Owner to gitlab-org/maintainers/rails-backend
    • Consider adding 'backend maintainer' to your Slack notification keywords

Manager checklist

Edited by Steve Abrams

Merge request reports