Skip to content

Add database review specialty to the registry

Steve Abrams requested to merge sabrams-master-patch-36653 into master

Why is this change being made?

In gitlab-org/gitlab (rails), we have reviewer and maintainer specialties for frontend, backend, database, etc.

With the container registry rolling out its own database, and the project and team growing, it may be helpful to have database-specific reviewers and maintainers identified: https://about.gitlab.com/handbook/engineering/projects/#container-registry. It would also benefit community contributors and team members not actively working on the registry who may reference this link to find the right people to ping.

We have database guidelines which generally follow the same guidelines for the rails project. Anytime an MR includes a database related update, be it a migration or query, either one or two individuals will specifically review from the database perspective.

I've created this MR as a place to have this discussion. If we decide to move forward, we will probably want to update a few other ymls with reviewer/maintainer roles.

Author Checklist

  • Provided a concise title for the MR
  • Added a description to this MR explaining the reasons for the proposed change, per say-why-not-just-what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added.
  • Assign reviewers for this change to the correct DRI(s)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the "Maintained by" section in on the page being edited.
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies.
  • If the changes affect team members, or warrant an announcement in another way, please consider posting an update in #whats-happening-at-gitlab linking to this MR.
    • If this is a change that directly impacts the majority of global team members, it should be a candidate for #company-fyi. Please work with internal communications and check the handbook for examples.
Edited by Steve Abrams

Merge request reports