Add Steve Abrams as a database maintainer
Background
- GitLab employee since May 2019 (~19 months).
- Database trainee maintainer since Jan 2020 (~11 months), reviewer since Aug 2019 (~5 months prior). Trainee issue: #5028 (closed)
Database trainee
- 80+ Database MRs reviewed
Documentation updates
- Add section for using alternative primary keys
- Add index timing note for large tables
- Query performance (timing) docs - This issue led to a great discussion!
- Add section for disabling an index
- Add details to alternative primary key section
Migration helper improvements
Becoming a maintainer
Over the past year I have learned a great deal and feel I've progressed considerably in my database expertise. I have been feeling confident about standard migration reviews and index analysis for some time now and over the past few months have focused in on improving my ability to review and analyze background migrations and more complicated queries, which I felt were my main shortcomings at the time. Although I feel I still have plenty to learn and am excited to continue expanding my knowledge in this area, I feel that I am at the point where I can contribute real value as a database maintainer for most of the issues and merge requests we face on a regular basis. I also feel this is the next step for me to continue to push myself to grow more confidence and expertise in the database domain.
Most importantly, I appreciate and understand the wealth and diversity of knowledge and experience that all of the database reviewers and maintainers have to share. I will continue to rely on the team whenever I run into something that I am uncertain of.
Self-assessed strengths
- Providing positive and engaging discussions.
- Referencing database guidelines in reviews.
- Index analysis.
- General migration guidelines.
- Understanding when to ask for assistance when I don't know something.
Self-assessed areas I could improve
- Familiarity with more of the various migration helpers we have available.
- More experience working with Arel.
- More experience optimizing or helping write complex queries (for example queries with window functions and recursive calls).
I think all of these areas will be improved as I work through more MRs, and being aware of areas where I do not have full confidence will help me understand when I should reach out for additional help and opinion from other maintainers.