Shell_metrics: remove applied and rename prechecked to validated

Context

Following-up on !8857 (merged), this MR renames the octez_mempool_pending_prechecked metric to octez_mempool_pending_validated, and removes octez_mempool_pending_applied.

Related: nomadic-labs/grafazos#9 (closed), nomadic-labs/grafazos!38 (merged)

Manually testing the MR

Checklist

• n/a Document the interface of any function added or modified (see the coding guidelines)
• n/a Document any change to the user interface, including configuration parameters (see node configuration)
• n/a Provide automatic testing (see the testing guide).
• For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
• Select suitable reviewers using the Reviewers field below.
• Select as Assignee the next person who should take action on that MR

changed milestone to %Mempool upgrade

added mempool metrics shell technical-debt labels

added 1 commit

• 5bd4f53a - Changelog: add entry on metrics removal/renaming

Compare with previous version

changed the description

mentioned in issue nomadic-labs/grafazos#9 (closed)

mentioned in merge request nomadic-labs/grafazos!38 (merged)

changed the description

added 1 commit

• dc1f02a2 - Changelog: add entry on metrics removal/renaming

Compare with previous version

marked the checklist item For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else). as completed

marked the checklist item Select suitable reviewers using the Reviewers field below. as completed

marked the checklist item Select as Assignee the next person who should take action on that MR as completed

requested review from @ACoquereau and @Killian-Delarue

assigned to @Killian-Delarue

Everything looks good to me! Thank you for your contribution

---

I,  , ran this inspection on Wed, 14 Jun 2023 16:23:59 +0000. I usually run inspections every 6 hours and will try to edit my own comment if I have any updates. For more information see the Tezos documentation.

I think it's ok to remove and rename, as you did your changes will be included in the master branch of Grafazos which is currently the main use of these metrics.

I tested it on https://grafana.obs.nomadic-labs.cloud/d/r_D9ykX4k/octez-full-dashboard-test?orgId=1&var-node_instance=i-038c639802121cea1, it works fine.

LGTM

approved this merge request

assigned to @ACoquereau and unassigned @Killian-Delarue

approved this merge request

I manually tested this MR by modifying my Grafana metric to use octez_mempool_pending_validated and it worked well. LGTM

assigned to @nomadic-margebot and unassigned @ACoquereau