SCORU/Node: allow to run without a configuration file
Context
Fixes #4212 (closed).
This MR allows for the rollup node to be run without a configuration file. If one is provided, the arguments on the command line take precedence over the values set in the configuration file.
An additional run
command is provided which allows to override some operators:
run <mode> for <smart-rollup-address> with operators [<operator>...]
Manually testing the MR
dune exec tezt/tests/main.exe -- -f sc_rollup.ml
Merge request reports
Activity
assigned to @mebsout
Everything looks good to me! Thank you for your contribution
I,
, ran this inspection onTue, 21 Mar 2023 16:24:30 +0000
. I usually run inspections every 6 hours and will try to edit my own comment if I have any updates. For more information see the Tezos documentation.added Improve UX scorunode labels
changed milestone to %Functional Rollup Node (2023Q1)
requested review from @ole.kruger and @romain.nl
mentioned in commit d5ef56df
added 2 commits
- 6d04a394 - SCORU/Node: Allow `without operators` to ignore operators from config
- d5ef56df - SCORU/Node: Backport !8148 (merged) to mumbai rollup node
requested review from @Killian-Delarue, @ilya.peresadin, @alocascio, @lthms, and @yrg and removed review request for @romain.nl
mentioned in issue #5185 (closed)
added 1 commit
- 95f20d4c - Doc: explain how to run rollup node without configuration file
assigned to @ole.kruger and unassigned @mebsout
requested review from @NicVolanschi and @romain.nl
- Resolved by Alain Mebsout
- Resolved by Ole Krüger
The
with|without
part is very confusing to me. It seems to suggest one isn't running with any operators.Instead wouldn't it be simpler to exclusively rely on the existence of the configuration file? The node configuration is
config file + cli config
and if the config file doesn't exist it defaults to default/empty.
assigned to @mebsout and unassigned @ole.kruger
assigned to @ole.kruger and unassigned @mebsout