Skip to content
Snippets Groups Projects

SCORU/Node: allow to run without a configuration file

Merged Alain Mebsout requested to merge alain@functori@no-config-scoru-node into master

Context

Fixes #4212 (closed).

This MR allows for the rollup node to be run without a configuration file. If one is provided, the arguments on the command line take precedence over the values set in the configuration file.

An additional run command is provided which allows to override some operators:

run <mode> for <smart-rollup-address> with operators [<operator>...]

Manually testing the MR

dune exec tezt/tests/main.exe -- -f sc_rollup.ml
Edited by Alain Mebsout

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • The doc change LGTM beyond a simple typo (to be fixed also on the Mumbai doc).

    • Resolved by Ole Krüger

      The with|without part is very confusing to me. It seems to suggest one isn't running with any operators.

      Instead wouldn't it be simpler to exclusively rely on the existence of the configuration file? The node configuration is config file + cli config and if the config file doesn't exist it defaults to default/empty.

  • Ole Krüger assigned to @mebsout and unassigned @ole.kruger

    assigned to @mebsout and unassigned @ole.kruger

  • Alain Mebsout assigned to @ole.kruger and unassigned @mebsout

    assigned to @ole.kruger and unassigned @mebsout

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading