WIP: Lib_p2p: rename point state's info "greylist" into "reconnection_delay"

The greylist term was ambiguous as it was used for the greylist tables, which concern temporarily banned addresses and peers, and a "greylist" mechanism which prevents the reconnection to a node shortly after its deconnection.

This MR changes:

• greylisting_config type name and field name into reconnection_delay_config
• greylisted_until field into reconnection_delayed_until
• greylisting_delay field into reconnection_delay
• greylisting_end field into reconnection_delay_end
• greylisted function into reconnection_delayed
• set_greylisted function into set_reconnection_delayed

Thank you for your contribution , I have one remark:

• Commit messages should be ≤ 70 characters:
  • → fa332a69: Lib_p2p: rename point state's info "greylist" into "reconnection_delay"
  • → 0d9e4371: Lib_p2p: rename point state's info "greylist" into "reconnection_delay"

---

I,  , ran this inspection on Mon, 30 Mar 2020 22:13:00 0000. I usually run inspections every 6 hours and will try to edit my own comment if I have any updates. For more information see the Tezos documentation.

changed the description

Looks good. It seems to change names in tho configuration file, so is backward-incompatible though. Should we have a transition period with both names? Or at least describe it carefully in a changelog?

You are right, I totally missed that point ! I'm switching to WIP the time to figure out how to make it possible to have both name working.

marked as a Work In Progress

added p2p 🌐 label

added 156 commits

• 16d4cc82...51465386 - 154 commits from branch tezos:master
• fa332a69 - Lib_p2p: rename point state's info "greylist" into "reconnection_delay"
• 0d9e4371 - Lib_p2p: rename point state's info "greylist" into "reconnection_delay"

Compare with previous version

Data encoding transition is a bit hackish, a better solution would be to have support for this in data-encoding nomadic-labs/data-encoding#6 .

Is it going to affect RPC endpoints ?

• /network/greylist/clear

Related to #837 (closed)

no, these are not related to this rpc

mentioned in merge request !1934 (merged)

changed the description

assigned to @julien.t

added shell label

Hi. has not been updated in almost a year. @julien.t do you plan on having it merge anytime soon, or can we close it for nom? Of course, in the latter case, you could always reopen it when you’d find the time to work on it again.

closed