Disable active request of full mempools from our peers in bakers

Context

This MR disables an explicit call in the bakers to fetch complete mempools from our peers which produces a lot of network activity. In the context of the %(2023Q4) - Layer 1 - Reduce Block time milestone, our experiments showed that this activity was very impactful on the node which made it delay consensus operations injection, treatment and propagation when mempools gets large, like in our experiments.

Here are reports of experiments with and without the patch (on top of several other unrelated optimisations):

Report with bakers requesting operations:

Report with bakers not requesting operations:

Notice that the quorum takes 1s less to be reached with the patch and results are overall better.

Checklist

• Document the interface of any function added or modified (see the coding guidelines)
• Document any change to the user interface, including configuration parameters (see node configuration)
• Provide automatic testing (see the testing guide).
• For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
• Select suitable reviewers using the Reviewers field below.
• Select as Assignee the next person who should take action on that MR

marked this merge request as ready

marked the checklist item Document the interface of any function added or modified (see the coding guidelines) as completed

marked the checklist item Document any change to the user interface, including configuration parameters (see node configuration) as completed

marked the checklist item Provide automatic testing (see the testing guide). as completed

marked the checklist item For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else). as completed

marked the checklist item Select suitable reviewers using the Reviewers field below. as completed

marked the checklist item Select as Assignee the next person who should take action on that MR as completed

requested review from @andrea.cerone, @ryan.tan3, @gabriel.moise, and @ACoquereau

assigned to @ACoquereau

changed milestone to %(2023Q4) - Layer 1 - Reduce Block time

added reduce-block-time label

Thank you for your contribution , I have one remark:

• There are changes to protocol-client-code:
  • → src/proto_017_PtNairob/lib_delegate/operation_worker.ml, src/proto_018_Proxford/lib_delegate/operation_worker.ml, src/proto_alpha/lib_delegate/operation_worker.ml
  • → Please make sure changes are properly replicated for all relevant protocols (e.g. src/proto_alpha, src/proto_0XX_PtBLaBLa, …).

---

I,  , ran this inspection on Wed, 22 Nov 2023 12:24:14 +0000. I usually run inspections every 6 hours and will try to edit my own comment if I have any updates. For more information see the Tezos documentation.

changed the description

added 125 commits

• 4dc78cd7...b98b02b4 - 124 commits from branch tezos:master
• c378eda6 - Bakers: don't request complete mempools from our peers at each block

Compare with previous version

approved this merge request

Code LGTM, I have tested it on a mainnet baker, and it worked as expected.

assigned to @gabriel.moise and unassigned @ACoquereau

approved this merge request

assigned to @vbotbol and unassigned @gabriel.moise

approved this merge request

LGTM

assigned to @nomadic-margebot and unassigned @vbotbol

added 36 commits

• c378eda6...d2c13e1e - 35 commits from branch tezos:master
• 14276319 - Bakers: don't request complete mempools from our peers at each block

Compare with previous version

merged

mentioned in commit 9e6e796c