prevent having both 'repo' and 'helmrelease_spec.chart.spec.version' set for a unit

Thomas Morinrequested to merge
loki-remove-unit-version into main

Closes #1671 (closed)

This MR updates sylva-units schema to avoid the issue described in #1671 (closed): we can't allow helmrelease_spec.chart.spec.version to be specified for a unit depending on a Gitrepository resource or else we have two places, possibly conflicting, where the chart version to use is specified (and incidentally, only one of those is being looked at by renovate).

The MR also improves the schema:

  • don't skip such checks for enabled: false units -> this precisely leads to missing problems like here for loki
  • simplify the schema allOf/anyOf hierarchy now that we don't skip enabled: false This improvements is brought in the first commit that is mostly in fact only an indentation change, although diff does not make it obvious.

Related MRs fixing the discrepancies:

Edited by Thomas Morin

Merge request reports