Skip to content

Ensure Telemetry is disabled in tests

Rémy Coutable requested to merge fix-telemetry-enabled-in-tests into master

What does this MR do and why?

Telemetry would be automatically enabled in master test suite because the GITLAB_SDK_APP_ID would be defined there.

It prevented the deployment of !2862 (merged): https://gitlab.com/gitlab-org/quality/triage-ops/-/jobs/7125505882

This MR ensures we mock the GITLAB_SDK_APP_ID to nil in tests.

Expected impact & dry-runs

These are strongly recommended to assist reviewers and reduce the time to merge your change.

See https://gitlab.com/gitlab-org/quality/triage-ops/-/tree/master/doc/scheduled#testing-policies-with-a-dry-run on how to perform dry-runs for new policies.

See https://gitlab.com/gitlab-org/quality/triage-ops/-/blob/master/doc/reactive/best_practices.md#use-the-sandbox-to-test-new-processors on how to make sure a new processor can be tested.

Action items

Edited by Rémy Coutable

Merge request reports