Skip to content

Update QA element to remove support for data-qa-selector

Will Meek requested to merge qa_element_testid into master

What does this MR do and why?

As per gitlab-org/quality/quality-engineering/team-tasks#1822 (closed) we have phased out usage of data-qa-selector as a Test page object attribute for E2E testing.

We have deprecated it in favour of data-testid for consistency with feature and frontend specs.

This change updates the page object element, which had been updated to use either data-qa-selector or data-testid to only use data-testid.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

Run any E2E specs, the specs should pass and not fail due to element not found.

eg.

CHROME_HEADLESS=false bundle exec bin/qa Test::Instance::All http://gdk.test:3000/ ./qa/specs/features/ee/browser_ui/13_secure/

Also - Check the Allure report/pipeline of this MR - the full E2E suite run should pass (or if failures - with known and unrelated issues)

Edited by Will Meek

Merge request reports