TRea - Phase out qa-selectors

What does this MR do and why?

Picking up some items from this list gitlab-org/quality/quality-engineering/team-tasks#1822 (closed)

• app/assets/javascripts/environments/components
• app/assets/javascripts/groups/components
• app/assets/javascripts/groups_projects/components
• app/assets/javascripts/import_entities/import_groups/components

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

changed milestone to %16.7

added QA Quality maintenancerefactor labels

assigned to @treagitlab

added typemaintenance label

added backend frontend labels

	2 Warnings
	This merge request contains lines with testid selectors. Please ensure e2e:package-and-test job is run.
	This merge request contains deprecated data-qa-selector attribute. Please use data-testid attribute instead.

testid selectors

The following changed lines in this MR contain testid selectors:

app/assets/javascripts/groups/components/groups.vue

+  <div class="groups-list-tree-container" data-testid="groups-list-tree-container">

app/assets/javascripts/groups/components/overview_tabs.vue

+              data-testid="groups-filter-field"

app/assets/javascripts/groups_projects/components/transfer_locations.vue

+            data-testid="transfer-locations-search"
-          data-testid="group-transfer-locations"
+        <div v-if="hasGroupTransferLocations" data-testid="group-transfer-locations">
+            data-testid="group-transfer-item"

app/assets/javascripts/import_entities/import_groups/components/import_table.vue

+      tdAttr: { 'data-testid': 'import-status-indicator' },
+          'data-testid': 'import-item',

app/views/shared/groups/_search_form.html.haml

+  = search_field_tag :filter, params[:filter], placeholder: s_('GroupsTree|Search by name'), class: 'group-filter-form-field form-control js-groups-list-filter', data: { testid: 'groups-filter-field' }, spellcheck: false, id: 'group-filter-form-field'

If the e2e:package-and-test job in the qa stage has run automatically, please ensure the tests are passing. If the job has not run, please start the trigger-omnibus-and-follow-up-e2e job in the qa stage and ensure the tests in follow-up-e2e:package-and-test-ee pipeline are passing.

For the list of known failures please refer to the latest pipeline triage issue.

If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.

Deprecated data-qa-selector selectors

The following lines in this MR contain deprecated data-qa-selector selectors:

app/assets/javascripts/environments/components/environment_item.vue

-        <a data-qa-selector="environment_link" :href="environmentPath">

app/assets/javascripts/groups/components/groups.vue

-  <div class="groups-list-tree-container" data-qa-selector="groups_list_tree_container">

app/assets/javascripts/groups/components/overview_tabs.vue

-              data-qa-selector="groups_filter_field"

app/assets/javascripts/groups_projects/components/transfer_locations.vue

-        data-qa-selector="namespaces_list"
-            data-qa-selector="namespaces_list_search"
-            data-qa-selector="namespaces_list_item"
-          data-qa-selector="namespaces_list_groups"
-            data-qa-selector="namespaces_list_item"

app/assets/javascripts/import_entities/import_groups/components/import_table.vue

-      tdAttr: { 'data-qa-selector': 'import_status_indicator' },
-          'data-qa-selector': 'import_item',
-          data-qa-selector="import_table"

app/views/shared/groups/_search_form.html.haml

-  = search_field_tag :filter, params[:filter], placeholder: s_('GroupsTree|Search by name'), class: 'group-filter-form-field form-control js-groups-list-filter', data: { qa_selector: 'groups_filter_field' }, spellcheck: false, id: 'group-filter-form-field'

Please ensure all deprecated data-qa-selector attributes are replaced with data-testid attributes in accordance with our Testing Guide.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	@ghinfey (UTC+0, same timezone as author)	@jessieay (UTC+9, 9 hours ahead of author)
frontend	@aalakkad (UTC+3, 3 hours ahead of author)	@deepika.guliani (UTC+5.5, 5.5 hours ahead of author)
QA	@nprabakaran (UTC+5.5, 5.5 hours ahead of author)	@at.ramya (UTC+5.5, 5.5 hours ahead of author)

Please check reviewer's status!

• Reviewer is available!
• Reviewer is unavailable!

Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

added 1 commit

• 1249af14 - Phase out qa-selectors in groups/components/

Compare with previous version

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits f26bdf93 and 0ea1bd3d

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	4.09 MB	4.09 MB	-	0.0 %
mainChunk	3.05 MB	3.05 MB	-	0.0 %

---

Note: We do not have exact data for f26bdf93. So we have used data from: c7ffb105.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.

Please look at the full report for more details

---

Read more about how this report works.

Generated by Danger

Allure report

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for 0ea1bd3d

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Plan             | 55     | 0      | 0       | 0     | 55    | ✅     |
| Data Stores      | 23     | 0      | 0       | 0     | 23    | ✅     |
| Create           | 54     | 0      | 7       | 0     | 61    | ✅     |
| Govern           | 57     | 0      | 0       | 0     | 57    | ✅     |
| Verify           | 31     | 0      | 0       | 0     | 31    | ✅     |
| Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
| Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
| Monitor          | 8      | 0      | 0       | 0     | 8     | ✅     |
| Analytics        | 2      | 0      | 0       | 0     | 2     | ✅     |
| Release          | 5      | 0      | 0       | 0     | 5     | ✅     |
| Manage           | 0      | 0      | 1       | 0     | 1     | ➖     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 235    | 0      | 10      | 0     | 245   | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+

e2e-package-and-test: test report for 0ea1bd3d

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Package          | 226    | 0      | 16      | 0     | 242   | ✅     |
| Verify           | 138    | 0      | 27      | 3     | 165   | ❗     |
| Plan             | 245    | 0      | 10      | 3     | 255   | ❗     |
| Create           | 543    | 0      | 65      | 0     | 608   | ✅     |
| Data Stores      | 117    | 0      | 1       | 0     | 118   | ✅     |
| Monitor          | 35     | 0      | 7       | 0     | 42    | ✅     |
| Systems          | 8      | 0      | 0       | 0     | 8     | ✅     |
| Govern           | 292    | 0      | 23      | 3     | 315   | ❗     |
| Configure        | 1      | 0      | 9       | 0     | 10    | ✅     |
| Fulfillment      | 8      | 0      | 69      | 0     | 77    | ✅     |
| Manage           | 40     | 0      | 10      | 1     | 50    | ❗     |
| GitLab Metrics   | 2      | 0      | 1       | 0     | 3     | ✅     |
| Framework sanity | 0      | 0      | 4       | 0     | 4     | ➖     |
| Analytics        | 7      | 0      | 0       | 0     | 7     | ✅     |
| Secure           | 5      | 1      | 3       | 0     | 9     | ❌     |
| Release          | 15     | 0      | 3       | 0     | 18    | ✅     |
| Growth           | 0      | 0      | 6       | 0     | 6     | ➖     |
| ModelOps         | 0      | 0      | 6       | 0     | 6     | ➖     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 1682   | 1      | 260     | 10    | 1943  | ❌     |
+------------------+--------+--------+---------+-------+-------+--------+

e2e-review-qa: test report for 0ea1bd3d

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Create           | 6      | 0      | 4       | 0     | 10    | ✅     |
| Govern           | 3      | 0      | 0       | 0     | 3     | ✅     |
| Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
| Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
| Plan             | 3      | 0      | 1       | 0     | 4     | ✅     |
| Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
| Data Stores      | 2      | 0      | 0       | 0     | 2     | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 18     | 0      | 7       | 0     | 25    | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+

added 3 commits

• f3bd4fc2 - Phase out qa-selectors in group_projects/components/
• 523dae20 - Phase out qa-selectors in import_groups/components/
• 9d1e9c1d - Fix group-filter-field testid

Compare with previous version

added 1 commit

• 2a040389 - Fix group-filter-field testid

Compare with previous version

marked this merge request as ready

changed title from Draft: Phase out qa-selectors to Phase out qa-selectors environments/components, groups/components, groups_projects/components, import_entities/import_groups/components

changed the description

requested review from @AndyWH

@AndyWH would you mind doing 1st review here?

mentioned in issue gitlab-org/quality/quality-engineering/team-tasks#1822 (closed)

requested review from @ddavison

approved this merge request

@AndyWH, thanks for approving this merge request.

This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break master, a new pipeline will be started shortly.

Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.