Skip to content

Build use golang 1.19.8

DJ Mountney requested to merge golang-1.19 into master

What does this MR do?

Changes the golang version to build GitLab to 1.19

Part of epic: Update golang to 1.19 (&9495 - closed)

Build use golang 1.19.8

  • Update the builder image 4.13.0
  • Updates to building using golang 1.19.8

Matching CNG MR: gitlab-org/build/CNG!1370 (merged)

These two MRs should be merged around the same time. And should be avoided on a Thursday/Friday as there will be less coverage as they are rolled out to the environents.

Upon merge, these the change needs to be communicated broadly via https://docs.gitlab.com/ee/development/go_guide/go_upgrade.html#communication-plan

Test plan

  • QA tests passing for FIPS and non FIPS builds
  • Confirm build was done with go 1.19 strings /opt/gitlab/embedded/bin/gitaly | grep 'go1\.' | tail -1
  • Confirm Omnibus Built services that are owned by distribution are working
    • prometheus - (is scraping metrics)
    • pgbouncer exporter - (metrics endpoint returns data)
    • redis-exporter - (metrics endpoint returns data)
    • postgres-exporter - (metrics endpoint returns data)
    • node-exporter - (metrics endpoint returns data)
    • alertmanager - (test trigger an alert)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • MR title and description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • Latest Merge Result pipeline is green.
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow.

For GitLab team members

If you don't have access to this, the reviewer should trigger these jobs for you during the review process.

  • The manual Trigger:ee-package jobs have a green pipeline running against latest commit.
  • If config/software or config/patches directories are changed, make sure the build-package-on-all-os job within the Trigger:ee-package downstream pipeline succeeded.
  • If you are changing anything SSL related, then the Trigger:package:fips manual job within the Trigger:ee-package downstream pipeline must succeed.
  • If CI configuration is changed, the branch must be pushed to dev.gitlab.org to confirm regular branch builds aren't broken.

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes.
  • Documentation created/updated.
  • Tests added.
  • Integration tests added to GitLab QA.
  • Equivalent MR/issue for the GitLab Chart opened.
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Robert Marshall

Merge request reports