Skip to content

Build with golang 1.19

DJ Mountney requested to merge golang-1.19 into master

What does this MR do?

Changes the golang version to build GitLab to 1.19

Part of epic: Update golang to 1.19 (gitlab-org&9495 - closed)

Build use golang 1.19.8

Matching Omnibus MR: gitlab-org/omnibus-gitlab!6851 (merged)

These two MRs should be merged around the same time. And should be avoided on a Thursday/Friday as there will be less coverage as they are rolled out to the environents.

Upon merge, these the change needs to be communicated broadly via https://docs.gitlab.com/ee/development/go_guide/go_upgrade.html#communication-plan

Test Plan

The individual components already have pipelines that include test runs that have been run in each of their projects as part of Update golang to 1.19 (gitlab-org&9495 - closed)

The one exception is gitlab-logger which has build tests, but no other tests run.

  • Confirm the debian built images are on 1.19.8
  • Confirm the ubi8 built images are on 1.19.8
  • Confirm the fips built images are on 1.19.8
  • Confirm the regular golang 1.19 charts and qa pass
    • Confirm gitlab-logger working as expected via checking review app pod logging output
  • Confirm the ubi golang 1.19 charts and qa pass
    • Confirm gitlab-logger working as expected via checking review app pod logging output
  • Confirm the fips golang 1.19 charts and qa pass
    • Confirm gitlab-logger working as expected via checking review app pod logging output

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Integration tests added to GitLab QA
  • The impact any change in container size has should be evaluated
Edited by Robert Marshall

Merge request reports