Add PostgreSQL 14 builds
What does this MR do?
Adds postgres 14 to the builds in order to test our support of it.
Related issues
- Relates to:
- Closes #7702 (closed)
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion
Required
-
Merge Request Title, and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks -
trigger-package
has a green pipeline running against latest commit
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Tests added -
Integration tests added to GitLab QA -
Equivalent MR/issue for the GitLab Chart opened
Merge request reports
Activity
added devopssystems groupdistribution sectioncore platform labels
assigned to @dustinmm80
- A deleted user
added featureaddition typefeature labels
10 Warnings 73358f00: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. 3db3ef91: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. bd60a222: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. ec59d6aa: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. ec59d6aa: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. c68dd66b: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. 942b37e0: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. fa9d1d49: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. 0c5eb628: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. You've made some changes to the software definitions.
Any change in software definition requires:
- package rebuild to verify that builds across the supported platforms are successful.
- manual verification to confirm the package is installable
- uses an approved license
If the change does not affect existing functionality, for example when
resolvingrubocop
warnings, adding comments, or fixing typos, add one of
the following labels:1 Message Please add the workflowready for review label once you think the MR is ready to for an initial review. Merge requests are handled according to the workflow documented in our handbook and should receive a response within the limit documented in our First-response SLO.
If you don't receive a response, please mention
@gitlab-org/distribution
, or one of our Project MaintainersIf needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded maintenancedependency label
added typemaintenance label and removed featureaddition typefeature labels
added 5 commits
-
3f9038ef...18e6bab8 - 4 commits from branch
master
- 43c9f366 - Add PostgreSQL 14 builds
-
3f9038ef...18e6bab8 - 4 commits from branch
I'm seeing this error at the end of package builds on dev
bundler: failed to load command: omnibus (/builds/gitlab/omnibus-gitlab/gems/ruby/3.0.0/bin/omnibus) /builds/gitlab/omnibus-gitlab/.bundle/local-omnibus/lib/omnibus/dependency_information.rb:72:in `block (2 levels) in collect_licenses': undefined method `version' for nil:NilClass (NoMethodError)
Maybe this is something I am missing with postgres versions in the MR? The error isn't very descriptive. @twk3 do you see that I am doing something wrong here?
- Resolved by Dustin Collins
added 13 commits
-
0c5eb628...86f98401 - 11 commits from branch
master
- 3c94f40c - Add PostgreSQL 14 builds
- fa9d1d49 - fix postgres config names
-
0c5eb628...86f98401 - 11 commits from branch
added 6 commits
- 3f9038ef - Add PostgreSQL 14 builds
- 43c9f366 - Add PostgreSQL 14 builds
- 7fc99207 - Merge branch 'add-postgres-14' of gitlab.com:gitlab-org/omnibus-gitlab into add-postgres-14
- 0c5eb628 - fix postgres config names
- 942b37e0 - fix postgresql patch
- baa8d92d - Merge branch 'add-postgres-14' of dev.gitlab.org:gitlab/omnibus-gitlab into add-postgres-14
Toggle commit listadded 1 commit
- c68dd66b - move file link logic to postgresql, update dependencies
- Resolved by Dustin Collins
Pipeline and dev pipeline are now green. Triggered an EE pipeline for QA. I will test a basic configure and upgrade with the omnibus-docker container.
- Resolved by Dustin Collins
added 22 commits
-
73358f00...129b5d27 - 21 commits from branch
master
- 748e28b5 - Merge branch 'master' into add-postgres-14
-
73358f00...129b5d27 - 21 commits from branch
Initial testing looks good. I am able to run the omnibus Docker container with postgres 14.7 without issue. I used this compose file for testing:
version: '3.6' services: gitlab: container_name: 'gitlab' image: 'registry.gitlab.com/gitlab-org/omnibus-gitlab/gitlab-ee:15.11.0-rfbranch.844895870.7888ea29-0' hostname: 'gitlab.dev' environment: GITLAB_OMNIBUS_CONFIG: | external_url 'http://gitlab.dev' letsencrypt['enable'] = false gitlab_rails['initial_root_password'] = 'rtrtrtrt' ports: - '8080:80' - '8443:443' shm_size: '256m'
Edited by Dustin Collinsmentioned in issue #7396 (closed)
mentioned in issue #7702 (closed)
Setting this MR to close issue #7702 (closed). Updating this MR to match changes made for PG13 bump,!5390 (diffs).
added 9 commits
-
748e28b5...63557e20 - 8 commits from branch
master
- 0d9d02ce - Merge branch 'master' into add-postgres-14
-
748e28b5...63557e20 - 8 commits from branch
added workflowready for review label
added workflowin review label and removed workflowready for review label
requested review from @dmakovey
- Resolved by Clemens Beck
Added a few related issues that will be impacted by this MR (and most likely should be addressed after this MR merge):
mentioned in issue gitlab-org/charts/gitlab#4118 (closed)
added workflowin dev label and removed workflowin review label
mentioned in merge request !6856 (merged)
added 142 commits
-
d631048e...9c20ae55 - 141 commits from branch
master
- 707db94f - merge from master, remove postgresql_old
-
d631048e...9c20ae55 - 141 commits from branch
5 Warnings 66a71ae4: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. bf387f04: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. e1d58435: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. ab9d182a: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. You've made some changes to the software definitions.
Any change in software definition requires:
- package rebuild to verify that builds across the supported platforms are successful.
- manual verification to confirm the package is installable
- uses an approved license
If the change does not affect existing functionality, for example when
resolvingrubocop
warnings, adding comments, or fixing typos, add one of
the following labels:If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 16 commits
-
a73de58d...d40cc26b - 15 commits from branch
master
- eacf7ddf - Merge branch 'master' into add-postgres-14
-
a73de58d...d40cc26b - 15 commits from branch
mentioned in merge request gitlab!121327 (merged)
added 4 commits
-
eacf7ddf...a9e0e5f8 - 2 commits from branch
master
- c81f1631 - Update psycopg2 dependency, postgresql_new
- bad8ba34 - Merge branch 'master' into add-postgres-14
-
eacf7ddf...a9e0e5f8 - 2 commits from branch