Skip to content

trailing slash breaks redis runit sv run file

Robert Marshall requested to merge fix-trailing-slash-in-redis-when-not-announcing-hostnames into master

What does this MR do?

trailing slash breaks redis runit sv run file

- If Omnibus GitLab is left to default settings, the redis runit sv run
  file will be broken due to a trailing slash introduced when the
  ability to announce by hostname was added

Related https://gitlab.com/gitlab-com/gl-infra/scalability/-/issues/1661

Related https://gitlab.com/gitlab-com/gl-infra/scalability/-/issues/1724

Changelog: fixed

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

Related issues

Related gitlab-com/gl-infra/scalability#1661 (closed)

Related gitlab-com/gl-infra/scalability#1724 (closed)

Noticed while reviewing !6101 (merged)

Introduced in !6027 (merged)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Robert Marshall

Merge request reports