redis: Add announce_ip_from_hostname support to sentinel
What does this MR do?
We recently introduced a announce_ip_from_hostname setting for redis, which modifies the runit service definition for redis.
However, we forgot to perform the same change for the sentinel service definition. Thus it is still announcing itself via IP addresses. That was discovered in here.
This patch uses the same announce_ip_from_hostname parameter to also enable hostnames for sentinel.
When enabled, it modifies the runit script to dynamically set '--sentinel announce-ip' "$(hostname -f)". Yes, that config flag does contain a space, this is quite ugly, but it's how redis works.
Related issues
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion
Required
-
Merge Request Title, and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks -
trigger-packagehas a green pipeline running against latest commit
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Tests added -
Integration tests added to GitLab QA -
Equivalent MR/issue for the GitLab Chart opened
Edited by Robert Marshall