Skip to content

Introduce redis.announce_ip_from_hostname option, to enable setting the hostname at runtime

Igor requested to merge announce-ip-from-hostname into master

What does this MR do?

We recently introduced hostname support for redis+sentinel in !5853 (merged). However, it is currently not possible to dynamically set the hostname based on hostname -f. Thus, it requires statically configuring the hostname for each IP, which means per-node configuration in chef, as opposed to per-role. That is quite brittle.

This patch introduces a new setting redis['announce_ip_from_hostname'], which is mutually exclusive with redis['announce_ip'].

When enabled, it modifies the runit script to dynamically set --replica-announce-ip "$(hostname -f)".

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Jason Plum

Merge request reports