What does this MR do?
external_http setting in rails is only used as a boolean value: https://gitlab.com/search?utf8=%E2%9C%93&search=external_http&group_id=9970&project_id=278964&scope=&search_code=true&snippets=false&repository_ref=master&nav_source=navbar
In !4919 (comment 485431592) we set it by default to
 which would be treated by rails as
This will create a bug when custom domains will be available even though they shouldn't. E.g. see discussion in #5930 (comment 484618255)
We already converted
external_https to be just a boolean flag a while ago, I think we should do the same for
Closes #5930 (closed)
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion
Merge Request Title, and Description are up to date, accurate, and descriptive
MR targeting the appropriate branch
MR has a green pipeline on GitLab.com
Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
trigger-packagehas a green pipeline running against latest commit