GitLab Pages "custom domain" options always appear on project (should be disabled))
Hi,
I originally posted on the forums, however I believe this is more a bug as we have noticed this on multiple instances.
We use the GitLab Pages feature, but do not have SSL enabled or allow any custom domains to be added (this would require a secondary IP anyway). However, since upgrading to 13.7 from 13.6 we noticed that the GitLab Pages settings have option to add a "new domain" and also checkbox to Force SSL redirect.
I would not expect to see these options if I do not have a secondary IP configured.
This "Force HTTPS (requires valid certificates)" was also enabled for nearly all projects for the past 2 years which caused all site using gitlab pages domain to redirect to HTTPS, which therefore then redirect to the signup/login page of the GitLab instance (with SSL miss-match error). The docs do not say specifically how to disable custom domains, and I check to make sure none of the options that are used in the "custom domain" docs section are set.
I opened the console
and check what the config values were, as used in the /app/views/projects/pages/show.html.haml.
Suggested workaround
- Uncomment in
gitlab.rb
:
gitlab_pages['external_https'] = []
gitlab_pages['external_https_proxyv2'] = []
- Run reconfigure
- Redeploy pages project