This commit formats our source code using gofmt.

Because we create MRs to the fields package from labkit-spec and the
generated MRs do not conform to gofmt formatting - I've elected to
exclude the fields packages from this formatting pass, to avoid
obfuscating future diffs.

For the same reason, I've elected to not set up automated formatting in
CI / lefthook until this can be given some dedicated thought.

Ran:
`gofmt -w **/*.go; git restore v2/field*/`

chore(v2): gofmt format non-fields packages

See merge request !552

Merged-by: Elliot Forbes <eforbes@gitlab.com>
Approved-by: Elliot Forbes <eforbes@gitlab.com>
Co-authored-by: Luke Hollinda <lhollinda@gitlab.com>

chore(mise): add compile task

See merge request !547

Merged-by: Elliot Forbes <eforbes@gitlab.com>
Approved-by: Elliot Forbes <eforbes@gitlab.com>
Reviewed-by: GitLab Duo <gitlab-duo@gitlab.com>
Co-authored-by: Luke Hollinda <lhollinda@gitlab.com>

fix(deps): update module gitlab.com/gitlab-com/gl-infra/platform/runway/fairway to v1.32.1

See merge request !561

Merged-by: João Pereira <jpereira@gitlab.com>
Approved-by: Sahand Abbasi <sabbasi@gitlab.com>
Approved-by: João Pereira <jpereira@gitlab.com>
Co-authored-by: GitLab Renovate Bot <ops-contact+gl-common-ci-tasks-self-renovate@gitlab.com>

chore(deps): update pre-commit hook gitlab-com/gl-infra/common-ci-tasks to v4.19

See merge request !548

Merged-by: Matias Alvarez <malvarez@gitlab.com>
Approved-by: Matias Alvarez <malvarez@gitlab.com>
Co-authored-by: GitLab Renovate Bot <ops-contact+gl-common-ci-tasks-self-renovate@gitlab.com>

This runs the `v2/httpclient` unit test suite in parallel. This is for
two reasons:

1. It makes tests run slightly faster (here: from 4s to 3s) and
2. it implicitly helps us discover problems should the client ever rely
on global state.

test(v2/httpclient): run in parallel

See merge request !567

Merged-by: Matias Alvarez <malvarez@gitlab.com>
Approved-by: Matias Alvarez <malvarez@gitlab.com>
Reviewed-by: GitLab Duo <gitlab-duo@gitlab.com>
Co-authored-by: Kev Kloss <kkloss@gitlab.com>

- Switch Config.DisableClientCommands from bool to *bool so the field
  is presence-aware and proto overrides propagate correctly (nil leaves
  any chart-level default in place).
- Bump fairway to pull in the matching pointer-typed proto field.
- Expand the suppression block with a comment naming each CLIENT
  subcommand go-redis emits on init (SETNAME, SETINFO,
  MAINT_NOTIFICATIONS) and why each option must be set independently,
  per review on !565.

- Convert DeprecatedByStandard from exported var to function returning
  deep copy to prevent callers from corrupting shared state
- Consolidate six AppendDeprecated/AppendDeprecatedDual tests into a
  single table-driven test
- Fix misleading comment about panic-on-drift in NewServiceMapping
- Replace unrealistic NewServiceMapping([]string{...}) calls with the
  actual API signature

feat(redis): add DisableClientCommands to suppress CLIENT subcommands

See merge request !565

Merged-by: Elliot Forbes <eforbes@gitlab.com>
Approved-by: Elliot Forbes <eforbes@gitlab.com>
Reviewed-by: Florian Forster <fforster@gitlab.com>
Reviewed-by: GitLab Duo <gitlab-duo@gitlab.com>
Co-authored-by: s.abbasi <sabbasi@gitlab.com>

chore(deps): update pre-commit hook gitlab-com/gl-infra/common-ci-tasks to v4.20

See merge request !568

Merged-by: Peter Leitzen <pleitzen@gitlab.com>
Approved-by: Peter Leitzen <pleitzen@gitlab.com>
Co-authored-by: GitLab Renovate Bot <ops-contact+gl-common-ci-tasks-self-renovate@gitlab.com>

Add Florian Forster and Sahand Abbasi to CODEOWNERS

See merge request !566

Merged-by: Luke Hollinda <lhollinda@gitlab.com>
Approved-by: Luke Hollinda <lhollinda@gitlab.com>
Reviewed-by: GitLab Duo <gitlab-duo@gitlab.com>
Co-authored-by: e_forbes <eforbes@gitlab.com>

fix(deps): update module gitlab.com/gitlab-com/gl-infra/platform/runway/fairway to v1.34.0

See merge request !570

Merged-by: Matias Alvarez <malvarez@gitlab.com>
Approved-by: Matias Alvarez <malvarez@gitlab.com>
Co-authored-by: GitLab Renovate Bot <ops-contact+gl-common-ci-tasks-self-renovate@gitlab.com>

chore(deps): update pre-commit hook gitlab-com/gl-infra/common-ci-tasks to v4.22

See merge request !569

Merged-by: Andrew Newdigate <andrew@gitlab.com>
Approved-by: Andrew Newdigate <andrew@gitlab.com>
Co-authored-by: GitLab Renovate Bot <ops-contact+gl-common-ci-tasks-self-renovate@gitlab.com>

Similar to the S3 provider, we build a native `*storage.Client` and hand
it to `gcsblob.OpenBucket` via `Options.Client`.

Reads use the JSON API (`storage.WithJSONReads`) as this was called out
as an initial requirement and will eventually become the default SDK
read path. If at somepoint we need access to the XML, we can add a
config option to toggle between the two.

gocloud's blob.Bucket.Close is a no-op for GCS, meaning the storage.Client
is never closed. Providers now returns an io.Closer that Client.Shutdown
closes alongside the bucket.

Merge branch 'lh-objectstore-gcs-provider-closer-followup' into 'lh-objectstore-uninstrumented-gcs-provider'

feat(v2/objectstore): return closer when opening bucket avoiding leaks

See merge request !571

Merged-by: Luke Hollinda <lhollinda@gitlab.com>
Approved-by: Matias Alvarez <malvarez@gitlab.com>
Reviewed-by: GitLab Duo <gitlab-duo@gitlab.com>
Reviewed-by: Matias Alvarez <malvarez@gitlab.com>

Add Uninstrumented GCS ObjectStore provider

See merge request !563

Merged-by: Matias Alvarez <malvarez@gitlab.com>
Approved-by: Matias Alvarez <malvarez@gitlab.com>
Reviewed-by: GitLab Duo <gitlab-duo@gitlab.com>
Reviewed-by: Matias Alvarez <malvarez@gitlab.com>
Co-authored-by: Luke Hollinda <lhollinda@gitlab.com>

This repo does not have markdown linting, causing this rule to be
triggered often during review.

I don't personally believe multi-line sentences degrade our
documentation quality. Removing this reduces review noise.

.codeclimate.yml and .mdlrc were added in 2018 for GitLab's legacy
Code Climate-based Code Quality feature. Current CI uses common-ci-tasks
templates with no code_quality job, so nothing reads these files. Also
drop the stale "validated by markdownlint" note from the Duo review
instructions, since no such linter runs.

chore(duo): remove .md rule that sentences must start on new line

See merge request !574

Merged-by: Matias Alvarez <malvarez@gitlab.com>
Approved-by: Matias Alvarez <malvarez@gitlab.com>
Co-authored-by: Luke Hollinda <lhollinda@gitlab.com>

chore: remove orphaned Code Climate and markdownlint config

See merge request !575

Merged-by: Matias Alvarez <malvarez@gitlab.com>
Approved-by: Matias Alvarez <malvarez@gitlab.com>
Co-authored-by: Luke Hollinda <lhollinda@gitlab.com>

An invalid GITLAB_TRACING value (for example the legacy v1
opentracing:// connection string that Runway injects by default) was
silently ignored, so the OTLP exporter fell back to its built-in
default of https://localhost:4318 and export failed with connection
refused, with no hint as to why.

Log a warning from NewWithConfig when the variable is set but cannot
be parsed. The raw value is not logged because header_* query
parameters may carry credentials. ParseTracingConfig and
ParseTracingConfigFromEnv remain silent so callers using them as pure
parsers are unaffected.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Combine the warns-when-invalid and does-not-warn cases into a single
table-driven test covering all permutations of the env var: unset,
empty, each valid scheme, and each invalid form.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

fix(v2/trace): warn when GITLAB_TRACING is set but not parseable

See merge request !576

Merged-by: Matias Alvarez <malvarez@gitlab.com>
Approved-by: Sahand Abbasi <sabbasi@gitlab.com>
Approved-by: Matias Alvarez <malvarez@gitlab.com>
Reviewed-by: GitLab Duo <gitlab-duo@gitlab.com>
Co-authored-by: e_forbes <eforbes@gitlab.com>

This list of "disabled" linters is misleading, as we have accidentally
disabled all linting other than the 5 default linters. This was
accidentally removed while upgrading golangci-lint.

This is a no-op, due to the current config misconfiguration.

Further context can be found in:
#123

Duo correctly pointed out during review that we will eventually rely on
depguard to enforce our "no labkit v1 imports in labkit v2" rule

chore(gofmt): enforce usage of `any` over `interface{}`

See merge request !577

Merged-by: Matias Alvarez <malvarez@gitlab.com>
Approved-by: Matias Alvarez <malvarez@gitlab.com>
Co-authored-by: Luke Hollinda <lhollinda@gitlab.com>

chore(v2/.golangci.yaml): comment and remove misnomer disable list

See merge request !578

Merged-by: Matias Alvarez <malvarez@gitlab.com>
Approved-by: Matias Alvarez <malvarez@gitlab.com>
Reviewed-by: GitLab Duo <gitlab-duo@gitlab.com>
Co-authored-by: Luke Hollinda <lhollinda@gitlab.com>

This was example was removed in response to review comments.
d2101e45

This commit reintroduces the example, to be included in a
follow up MR.

feat: Add functionality for services to handle logging settings

See merge request !496

Merged-by: Matias Alvarez <malvarez@gitlab.com>
Approved-by: Luke Hollinda <lhollinda@gitlab.com>
Reviewed-by: GitLab Duo <gitlab-duo@gitlab.com>
Reviewed-by: Matias Alvarez <malvarez@gitlab.com>

chore(deps): update pre-commit hook gitlab-com/gl-infra/common-ci-tasks to v4.25

See merge request !572

Merged-by: Elliot Forbes <eforbes@gitlab.com>
Approved-by: Elliot Forbes <eforbes@gitlab.com>
Co-authored-by: GitLab Renovate Bot <ops-contact+gl-common-ci-tasks-self-renovate@gitlab.com>

chore(v2/fields): re-add deleted ServiceMapping example

See merge request !581

Merged-by: Matias Alvarez <malvarez@gitlab.com>
Approved-by: Matias Alvarez <malvarez@gitlab.com>
Co-authored-by: Luke Hollinda <lhollinda@gitlab.com>

feat: update field constants (labkit-spec v1.0)

See merge request !583

Merged-by: Matias Alvarez <malvarez@gitlab.com>
Approved-by: Matias Alvarez <malvarez@gitlab.com>
Co-authored-by: service-platforms-labkit <service-platforms-labkit@gitlab.com>

fix(deps): update module gitlab.com/gitlab-com/gl-infra/platform/runway/fairway to v1.35.1

See merge request !579

Merged-by: Andrew Newdigate <andrew@gitlab.com>
Approved-by: Andrew Newdigate <andrew@gitlab.com>
Co-authored-by: GitLab Renovate Bot <ops-contact+gl-common-ci-tasks-self-renovate@gitlab.com>

chore(deps): update registry.gitlab.com/gitlab-com/gl-infra/common-ci-tasks-images/golang-fips docker tag to v1.26.5

chore(deps): update pre-commit hook gitlab-com/gl-infra/common-ci-tasks to v4.29

See merge request !585

Merged-by: Andrew Newdigate <andrew@gitlab.com>
Approved-by: Andrew Newdigate <andrew@gitlab.com>
Co-authored-by: GitLab Renovate Bot <ops-contact+gl-common-ci-tasks-self-renovate@gitlab.com>

Merge branch 'renovate/registry.gitlab.com-gitlab-com-gl-infra-common-ci-tasks-images-golang-fips-1.x' into 'master'

chore(deps): update registry.gitlab.com/gitlab-com/gl-infra/common-ci-tasks-images/golang-fips docker tag to v1.26.5

See merge request !584

Merged-by: Andrew Newdigate <andrew@gitlab.com>
Approved-by: Andrew Newdigate <andrew@gitlab.com>
Co-authored-by: GitLab Renovate Bot <ops-contact+gl-common-ci-tasks-self-renovate@gitlab.com>

fix(deps): update module gitlab.com/gitlab-com/gl-infra/platform/runway/fairway to v1.36.0

See merge request !586

Merged-by: Matias Alvarez <malvarez@gitlab.com>
Approved-by: Matias Alvarez <malvarez@gitlab.com>
Approved-by: Andrew Newdigate <andrew@gitlab.com>
Co-authored-by: GitLab Renovate Bot <ops-contact+gl-common-ci-tasks-self-renovate@gitlab.com>

The fips build tag currently assumes the golang-fips toolchain:
fips.go imports crypto/boring unconditionally and Enabled() only
consults boring.Enabled(). Under upstream Go's native FIPS 140-3
module (selected via GOFIPS140; module v1.0.0 holds CMVP certificate
5247), the boringcrypto build tag is not set, so crypto/boring has no
buildable files and any build using -tags fips fails to compile:

    imports crypto/boring: build constraints exclude all Go files
    in .../src/crypto/boring

Even where crypto/boring is buildable, boring.Enabled() is always
false under the native module, so Enabled() would misreport FIPS as
disabled (gitlab-shell selects SSH algorithm sets based on it) and
Check() would log a misleading message about a missing external SSL
library.

Isolate the crypto/boring probe behind the boringcrypto build tag
(fips/boring.go, with a fips/notboring.go fallback returning false)
and report FIPS mode when either backend is active:

    Enabled() == boringEnabled() || fips140.Enabled()

crypto/fips140 is available since Go 1.24; the go directive already
requires 1.25. Check() now logs which backend is active. The non-fips
build (notfips.go) intentionally keeps returning false.

Tests: TestCheckMatchesEnabled pins the Check()==Enabled() contract
(the two probe backends independently and could drift). The kernel
FIPS flag test is gated on a per-arm boringBuilt constant: without a
BoringCrypto-compatible backend compiled in, the kernel flag has no
bearing on Enabled(), and a native-toolchain fips-tagged test run on
a FIPS-mode kernel must not fail. TestEnabledNativeModule covers the
GOFIPS140 path.

CI: add a test-fips-native job (plain golang image, GOFIPS140=v1.0.0)
so the native-module path is actually exercised; the existing
test-fips job cannot cover it because cmd/go rejects GOFIPS140
combined with GOEXPERIMENT=boringcrypto.

See:
https://gitlab.com/gitlab-org/distribution/team-tasks/-/work_items/1706
gitlab-org/build/CNG!3010
https://csrc.nist.gov/projects/cryptographic-module-validation-program/certificate/5247
https://go.dev/doc/security/fips140

Co-Authored-By: Claude <noreply@anthropic.com>

fix: support Go's native FIPS 140-3 module in fips package

See merge request !582

Merged-by: Luke Hollinda <lhollinda@gitlab.com>
Approved-by: Luke Hollinda <lhollinda@gitlab.com>
Reviewed-by: GitLab Duo <gitlab-duo@gitlab.com>
Co-authored-by: Jason Plum <jplum@gitlab.com>