Skip to content

Fix ::Gitlab::Kubernetes::RolloutStatus resolving

Vladimir Shushlin requested to merge fix-mock-deployment-service-in-dev into master

What does this MR do?

Fix exception in development:

uninitialized constant EE::Gitlab::Kubernetes excluded from capture: DSN not set
  
NameError (uninitialized constant EE::Gitlab::Kubernetes):
  
ee/app/models/ee/mock_deployment_service.rb:8:in `rollout_status'
ee/app/models/ee/environment.rb:50:in `rollout_status'
app/serializers/base_serializer.rb:16:in `represent'
app/serializers/concerns/with_pagination.rb:21:in `represent'
app/serializers/environment_serializer.rb:23:in `block in represent'
app/serializers/environment_serializer.rb:20:in `map'
app/serializers/environment_serializer.rb:20:in `represent'
app/controllers/projects/environments_controller.rb:200:in `serialize_environments'
app/controllers/projects/environments_controller.rb:24:in `block (2 levels) in index'
app/controllers/projects/environments_controller.rb:18:in `index'
lib/gitlab/i18n.rb:55:in `with_locale'
lib/gitlab/i18n.rb:61:in `with_user_locale'
app/controllers/application_controller.rb:434:in `set_locale'
lib/gitlab/middleware/rails_queue_duration.rb:27:in `call'
lib/gitlab/metrics/rack_middleware.rb:17:in `block in call'
lib/gitlab/metrics/transaction.rb:55:in `run'
lib/gitlab/metrics/rack_middleware.rb:17:in `call'
lib/gitlab/middleware/multipart.rb:103:in `call'
lib/gitlab/request_profiler/middleware.rb:16:in `call'
lib/gitlab/query_limiting/middleware.rb:17:in `block in call'
lib/gitlab/query_limiting/transaction.rb:39:in `run'
lib/gitlab/query_limiting/middleware.rb:16:in `call'
ee/lib/gitlab/jira/middleware.rb:17:in `call'
lib/gitlab/middleware/go.rb:20:in `call'
lib/gitlab/etag_caching/middleware.rb:25:in `call'
lib/gitlab/middleware/correlation_id.rb:16:in `block in call'
lib/gitlab/correlation_id.rb:15:in `use_id'
lib/gitlab/middleware/correlation_id.rb:15:in `call'
lib/gitlab/middleware/read_only/controller.rb:42:in `call'
lib/gitlab/middleware/read_only.rb:18:in `call'
lib/gitlab/middleware/basic_health_check.rb:25:in `call'
lib/gitlab/request_context.rb:26:in `call'
lib/gitlab/middleware/static.rb:11:in `call'
lib/gitlab/webpack/dev_server_middleware.rb:27:in `perform_request'
lib/gitlab/metrics/requests_rack_middleware.rb:29:in `call'
lib/gitlab/middleware/release_env.rb:13:in `call'

If I understand right, problem comes from having ::EE::Gitlab constant, and it was created in https://gitlab.com/gitlab-org/gitlab-ee/commit/3c289543bc4313ceb676e6078cb040586f0252ce , when this service was exctracted from controller

Edited by Vladimir Shushlin

Merge request reports