Skip to content

(Part 6) FE multiple approval rules - fallback rule & mr edit

What does this MR do?

  • Updates the project settings components to show a "Fallback Rule" based on this requirement change.
  • Adds the components and store for the MR edit page.

To run locally, enable the approval_rules and multiple_approval_rules flag.

MR Instructions!

This points to Part 5 https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9432

What's going to come in later MR's?

What are the relevant issue numbers?

Part of #1979 (closed)

Part of https://gitlab.com/gitlab-org/gitlab-ee/issues/8350 (FE)

Screenshots

Old Project Settings (current feature branch) New Project Settings
Screen_Shot_2019-02-05_at_4.11.35_AM 20190205_1979_project_settings_demo
MR Edit (with project rules) MR Edit (with no rules and override) MR Edit demo
Screen_Shot_2019-02-05_at_4.49.39_AM Screen_Shot_2019-02-05_at_4.51.38_AM 20190205_1979_mr_edit_approvers_demo

Does this MR meet the acceptance criteria?

Edited by Paul Slaughter

Merge request reports