Skip to content

FE for "Multiple blocking merge request approval rules"

Paul Slaughter requested to merge 1979-fe-multiple-approval-rules into master

(CE Port https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/25193)

What does this MR do?

This is a feature branch for the FE code for #1979 (closed) that has passed FE review. It is in WIP status until the BE is merged to master.

Instructions!

This MR should not be merged until:

TODO

MR's still need to be made for the following:

  • License feature with only a single approval rule
  • Docs

Implementation design

Vuex:

Both the project_settings and mr_edit view have very similar (but slightly different) behavior. For this reason, we have broken up the Vuex store into modules so that we can easily substitute one module for another.

  • base this is the base module that contains some shared state / mutations. It isn't included directly, just "extended" by the more specific modules.
  • project_settings this module implements the same interface of actions as mr_edit, but it implements the behavior used in the project approval settings Vue instance.
  • mr_edit this module implements the same interface of actions as project_settings, but it implements the behavior used in the MR edit approval section Vue instance.

What are the relevant issue numbers?

Does this MR meet the acceptance criteria?

Edited by Paul Slaughter

Merge request reports