Skip to content
Snippets Groups Projects

Support Project Avatar removal in REST API

This change set adds support to remove project avatars using the REST API, much like it's already possible for the Topics API.

To support this I've changed the POST | PUT /projects endpoint to be handled by workhorse. Can someone with more experience and the big picture verify this particular part of the change? Is this something which makes sense? Is it implemented correctly?

If this is the case and all looks good with the Projects API here, I'll also implement similar changes to the other Avatarable endpoints, like Groups and Users.

This change was driven by a request in the terraform provider.

/cc @nagyv-gitlab @nmezzopera can you help me triage this?

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Allen Cook approved this merge request

    approved this merge request

  • Allen Cook removed review request for @acook.gitlab

    removed review request for @acook.gitlab

  • requested review from @msedlakjakubowski

  • Marcin Sedlak-Jakubowski approved this merge request

    approved this merge request

  • removed review request for @msedlakjakubowski

  • added 1 commit

    • 45a5a8a9 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • requested review from @acook.gitlab

  • Nick Veenhof added 1 deleted label

    added 1 deleted label

  • Moving it to ready for review, as it's unclear what actions need to be taken for the author to move this forward

  • @acook.gitlab, this Community contribution is ready for review.

    • Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
    • Add the workflowin dev label if the merge request needs action from the author. This message was generated automatically. You're welcome to improve it.
  • added workflowin dev label and removed workflowready for review label

  • added 5233 commits

    Compare with previous version

  • added 1 commit

    • 5223a34c - Support Project Avatar removal in REST API

    Compare with previous version

  • added 1 commit

    • b323ddac - Support Project Avatar removal in REST API

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading