Revert "Merge branch '353926' into 'master'"

assigned to @oregand

changed milestone to %Backlog

added Category:Wiki [deprecated] Accepting merge requests customer devopscreate groupeditor [DEPRECATED] priority3 sectiondev severity3 typebug labels

added workflowin review label

Suggested Reviewers (beta)

The individuals below may be good candidates to participate in the review based on various factors.

You can use slash commands in comments to quickly assign /assign_reviewer @user1.

Suggested Reviewers
`@dbalexandre`, `@marin`, `@tigerwnz`, `@rymai`, `@mayra-cabrera`

If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".

changed the description

added backend feature flag labels

1 Message

CHANGELOG missing:

If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog.

If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message.

If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Michał Wielich (`@michold`) (UTC+2, 1 hour ahead of `@oregand`)	Kerri Miller (`@kerrizor`) (UTC-7, 8 hours behind `@oregand`)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

mentioned in issue #359081 (closed)

Hey @kerrizor

Would you be able to review this revert?

requested review from @kerrizor

changed milestone to %15.2

added 9 commits

87f6115f...1fc5fbfb - 8 commits from branch master
1d170499 - Revert "Merge branch '353926' into 'master'"

Compare with previous version

Allure report

allure-report-publisher generated test report!

review-qa-blocking: test report for 1d170499

expand test summary

+---------------------------------------------------------------------------+
|                              suites summary                               |
+----------------------+--------+--------+---------+-------+-------+--------+
|                      | passed | failed | skipped | flaky | total | result |
+----------------------+--------+--------+---------+-------+-------+--------+
| Plan                 | 47     | 0      | 1       | 47    | 48    | ❗     |
| Create               | 23     | 0      | 2       | 23    | 25    | ❗     |
| Manage               | 37     | 0      | 2       | 39    | 39    | ❗     |
| Verify               | 12     | 0      | 1       | 12    | 13    | ❗     |
| Configure            | 0      | 0      | 1       | 0     | 1     | ➖     |
| Protect              | 2      | 0      | 0       | 2     | 2     | ❗     |
| Package              | 0      | 0      | 1       | 0     | 1     | ➖     |
| Secure               | 2      | 0      | 0       | 2     | 2     | ❗     |
| Version sanity check | 0      | 0      | 1       | 0     | 1     | ➖     |
+----------------------+--------+--------+---------+-------+-------+--------+
| Total                | 123    | 0      | 9       | 125   | 132   | ❗     |
+----------------------+--------+--------+---------+-------+-------+--------+

package-and-qa-ff-disabled: test report for 1d170499

expand test summary

+---------------------------------------------------------------------------+
|                              suites summary                               |
+----------------------+--------+--------+---------+-------+-------+--------+
|                      | passed | failed | skipped | flaky | total | result |
+----------------------+--------+--------+---------+-------+-------+--------+
| Create               | 425    | 25     | 18      | 3     | 468   | ❌     |
| Manage               | 292    | 29     | 9       | 1     | 330   | ❌     |
| Plan                 | 146    | 16     | 0       | 0     | 162   | ❌     |
| Secure               | 57     | 6      | 6       | 1     | 69    | ❌     |
| Verify               | 111    | 9      | 9       | 0     | 129   | ❌     |
| Package              | 0      | 0      | 9       | 0     | 9     | ➖     |
| Version sanity check | 0      | 0      | 3       | 0     | 3     | ➖     |
| Configure            | 0      | 0      | 9       | 0     | 9     | ➖     |
| Release              | 18     | 0      | 0       | 0     | 18    | ✅     |
| Fulfillment          | 6      | 0      | 33      | 0     | 39    | ✅     |
| Product Intelligence | 6      | 0      | 0       | 0     | 6     | ✅     |
| Protect              | 6      | 0      | 0       | 0     | 6     | ✅     |
+----------------------+--------+--------+---------+-------+-------+--------+
| Total                | 1067   | 85     | 96      | 5     | 1248  | ❌     |
+----------------------+--------+--------+---------+-------+-------+--------+

package-and-qa-ff-enabled: test report for 1d170499

expand test summary

+---------------------------------------------------------------------------+
|                              suites summary                               |
+----------------------+--------+--------+---------+-------+-------+--------+
|                      | passed | failed | skipped | flaky | total | result |
+----------------------+--------+--------+---------+-------+-------+--------+
| Plan                 | 162    | 0      | 0       | 0     | 162   | ✅     |
| Create               | 450    | 0      | 18      | 2     | 468   | ❗     |
| Verify               | 120    | 0      | 9       | 0     | 129   | ✅     |
| Fulfillment          | 6      | 0      | 33      | 0     | 39    | ✅     |
| Manage               | 321    | 0      | 9       | 1     | 330   | ❗     |
| Secure               | 63     | 0      | 6       | 0     | 69    | ✅     |
| Package              | 0      | 0      | 9       | 0     | 9     | ➖     |
| Release              | 18     | 0      | 0       | 0     | 18    | ✅     |
| Version sanity check | 0      | 0      | 3       | 0     | 3     | ➖     |
| Configure            | 0      | 0      | 9       | 0     | 9     | ➖     |
| Product Intelligence | 6      | 0      | 0       | 0     | 6     | ✅     |
| Protect              | 6      | 0      | 0       | 0     | 6     | ✅     |
+----------------------+--------+--------+---------+-------+-------+--------+
| Total                | 1152   | 0      | 96      | 3     | 1248  | ❗     |
+----------------------+--------+--------+---------+-------+-------+--------+