Remove wiki_front_matter FF
What does this MR do and why?
A small MVC for: #353926 (closed) to add the feature by default.
Screenshots or screen recordings
N/A
How to set up and validate locally
N/A
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @oregand
changed milestone to %14.9
Allure report
allure-report-publisher
generated test report for 3fbac83e!review-qa-reliable:
test report
review-qa-smoke: test report- Resolved by Luke Duncalfe
Hola y'all
In an effort to clean up our feature flag's I wanted to reach out and see if this one can be removed? Going from: !27706 (merged) it seems we wrapped this functionality in a feature flag but never had a follow-up rollout of the feature. Are we in a place where we could consider enabling this by default or was there a reason we opted not to do that already?
requested review from @.luke and @alexkalderimis
removed review request for @.luke
removed review request for @alexkalderimis
added sectiondev label
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
added 192 commits
-
4fe02d70...8838bf2c - 189 commits from branch
master
- 6fe85c45 - Remove wiki_front_matter FF
- 1dccb359 - spec: remove feature gate
- 0099a438 - spec: remove feature gate
Toggle commit list-
4fe02d70...8838bf2c - 189 commits from branch
mentioned in issue #353959 (closed)
added 40 commits
-
0099a438...9e20fe77 - 37 commits from branch
master
- a3e6c9cf - Remove wiki_front_matter FF
- 2734f459 - spec: remove feature gate
- 1dc1fbd0 - spec: remove feature gate
Toggle commit list-
0099a438...9e20fe77 - 37 commits from branch
Async update
- Enabled on production: https://gitlab.slack.com/archives/C101F3796/p1646151330613799
- Testing to take place today/tomorrow
- No documentation is needed
- Rollout issue for reference: #353959 (closed)
added 193 commits
-
1dc1fbd0...c9d6d99d - 190 commits from branch
master
- 6b0a150f - Remove wiki_front_matter FF
- 3aa42b59 - spec: remove feature gate
- 1439b9f3 - spec: remove feature gate
Toggle commit list-
1dc1fbd0...c9d6d99d - 190 commits from branch
added 174 commits
-
1439b9f3...96f5de2a - 171 commits from branch
master
- 7f093289 - Remove wiki_front_matter FF
- b8b26e4d - spec: remove feature gate
- c95cc97b - spec: remove feature gate
Toggle commit list-
1439b9f3...96f5de2a - 171 commits from branch
added 33 commits
-
c95cc97b...baa9281a - 30 commits from branch
master
- 7812fa8a - Remove wiki_front_matter FF
- 3e217a31 - spec: remove feature gate
- b7adf78e - spec: remove feature gate
Toggle commit list-
c95cc97b...baa9281a - 30 commits from branch
4 Warnings c8ef6a56: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. df9fe984: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. e05d654e: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
If needed, you can retry the
danger-review
job that generated this comment.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Roy Zwambag ( @rzwambag
) (UTC+1, 8 hours ahead of@oregand
)Thong Kuah ( @tkuah
) (UTC+13, 20 hours ahead of@oregand
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Dangeradded 177 commits
-
b7adf78e...89d18cb9 - 174 commits from branch
master
- 878cba25 - Remove wiki_front_matter FF
- 5a3274e2 - spec: remove feature gate
- 5c117c72 - spec: remove feature gate
Toggle commit list-
b7adf78e...89d18cb9 - 174 commits from branch
added 221 commits
-
5c117c72...79a3f536 - 218 commits from branch
master
- c7d4d06e - Remove wiki_front_matter FF
- 7fae381c - spec: remove feature gate
- c70a82a3 - spec: remove feature gate
Toggle commit list-
5c117c72...79a3f536 - 218 commits from branch
added 179 commits
-
c70a82a3...7f7ca69c - 176 commits from branch
master
- 1b1ba410 - Remove wiki_front_matter FF
- 4d22f980 - spec: remove feature gate
- 7a8de943 - spec: remove feature gate
Toggle commit list-
c70a82a3...7f7ca69c - 176 commits from branch
added 219 commits
-
7a8de943...098f3222 - 216 commits from branch
master
- 1d3cf6da - Remove wiki_front_matter FF
- 241f68a8 - spec: remove feature gate
- 8289cd9c - spec: remove feature gate
Toggle commit list-
7a8de943...098f3222 - 216 commits from branch
added 139 commits
-
8289cd9c...60fe3a6a - 136 commits from branch
master
- d7d1221e - Remove wiki_front_matter FF
- 051ae757 - spec: remove feature gate
- 2bb18884 - spec: remove feature gate
Toggle commit list-
8289cd9c...60fe3a6a - 136 commits from branch
added 27 commits
-
2bb18884...c168932c - 24 commits from branch
master
- 91b4bcd7 - Remove wiki_front_matter FF
- 4671d068 - spec: remove feature gate
- a40af979 - spec: remove feature gate
Toggle commit list-
2bb18884...c168932c - 24 commits from branch
- Resolved by Luke Duncalfe
Hey y'all
So we've completed the rollout of this flag early last week and have not seen any adverse effects on the ~"group::editor" side, given that I think it should be safe to proceed with the removal of the feature flag code. Would y'all be open to giving this a review?
requested review from @.luke and @alexkalderimis
@alexkalderimis
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
removed review request for @alexkalderimis
added 47 commits
-
a40af979...d959694a - 44 commits from branch
master
- a0caa3db - Remove wiki_front_matter FF
- f2e1396d - spec: remove feature gate
- 3a128fb3 - spec: remove feature gate
Toggle commit list-
a40af979...d959694a - 44 commits from branch
- Resolved by Luke Duncalfe
- Resolved by Luke Duncalfe
removed review request for @.luke
added 139 commits
-
3a128fb3...9f9b9070 - 135 commits from branch
master
- 36272bcc - Remove wiki_front_matter FF
- e05d654e - spec: remove feature gate
- df9fe984 - spec: remove feature gate
- d20d26b7 - chore: remove shared example
Toggle commit list-
3a128fb3...9f9b9070 - 135 commits from branch
Thank you for the review! I have updated the shared example code and left a response to your question about the feature in general, please let me know what your thoughts are
requested review from @.luke
- Resolved by Luke Duncalfe
- Resolved by Luke Duncalfe
enabled an automatic merge when the pipeline for a5927644 succeeds
mentioned in commit 686b1c8e
added workflowstaging-canary label and removed workflowin review label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!797 (merged)
mentioned in commit vishwin/freebsd-ports@c617954a
mentioned in commit 87f6115f
mentioned in merge request !92104 (merged)
mentioned in commit 1d170499
mentioned in commit gitlab-jh/jh-team/gitlab@ae2b36a1
mentioned in merge request !132331 (merged)
mentioned in commit gitlab-jh/jh-team/gitlab@b5f6d77c