Skip to content

Display invalid approvals on merge request widget

Zamir Martins requested to merge display_invalid_approvals_frontend into master

What does this MR do and why?

Display invalid approvals on merge request widget.

Invalid will be applied to MRs:

  • when the author is the only eligible approver.
  • when there is no eligible approver assigned to the rule.

Related issue: #334698 (closed)

Backend related MR: !87596 (merged)

Documentation related MR: !88943 (merged)

Screenshots or screen recordings

CE

ce_version

EE (user who is an approver)

ee_approver

EE (user who is not an approver)

ee_not_approver

Updated with fix for Learn more and .

Screen_Shot_2022-06-02_at_11.43.09_AM

How to set up and validate locally

  1. Create a security project as described in the docs
  2. Create a new scan result policy with the project owner
  3. [Scenario 1] Assign either an invalid user or group as approvers.
  4. [Scenario 2] Assign approver to be the same as the MR author.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Zamir Martins

Merge request reports