Ambiguity in regards to whether a MR has been approved automatically even when there are defined rules
Why are we doing this work
While investigating a unexpected behaviour in regards to Vulnerability-Check MR approval rules, it was identified that the following behaviour seems to be as designed. The automatic approval in the scenario described below is unexpected to the end user and is not well explained in the UI.
Steps to reproduce:
Proposal / Expected behaviour
We need to either:
- reword the approval related sentence; or
- add extra information to provide more context of the current behaviour.
The exact solution is pending design.
Note: An alternative solution of keeping the required approval was considered and was not selected. For context see #334698 (comment 910654934)
Relevant links
Original issue: &6237 (comment 609639123)
Non-functional requirements
-
Documentation: -
Feature flag: -
Performance: -
Testing:
Implementation plan
-
documentation Add information in regards to the invalid rules into merge request approvals. -
backend Add invalid approvers rules as part of the approval state. -
frontend Add information in regards to the invalid rules summarized into approvals. -
frontend Set approvals to Invalidfor each rules into policy list.
Edited by Zamir Martins


