Skip to content

Add invalid approvers to be further used by the MR widget frontend code

Zamir Martins requested to merge display_invalid_approvals_on_mr_widget into master

What does this MR do and why?

Add invalid approvers to be further used by the MR widget frontend code.

Invalid will be applied to MRs:

  • when the author is the only eligible approver.
  • when there is no eligible approver assigned to the rule.

Related issue: #334698 (closed)

Frontend related MR: !88941 (merged)

Documentation related MR: !88943 (merged)

Metrics will be added as part of this MR: !89345 (merged)

How to set up and validate locally

  1. Create a security project as described in the docs
  2. Create a new scan result policy with the project owner
  3. [Scenario 1] Assign either an invalid user or group as approvers.
  4. [Scenario 2] Assign approver to be the same as the MR author.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Zamir Martins

Merge request reports