Fix vulnerability report project filter loading icon

What does this MR do and why?

This MR fixes some issues with the loading spinner for the project filter on the group and instance vulnerability reports:

1. Previously, when doing a search and the next page of results was being loaded, the entire list was replaced with a spinner instead of just showing a spinner at the bottom. This has been fixed:

Before	After
Peek_2022-05-26_17-20	Peek_2022-05-26_17-30

2. Previously, two different loading spinners were used, depending on whether the first page of results is being loaded (larger spinner) or additional pages are (smaller spinner at the bottom of the dropdown). The logic to manage this was a small nightmare to maintain, so it has been replaced with a single smaller spinner that's shown for both. This also affects the All options item, which is now shown for the first page load, whereas it wasn't before:

Before	After
Peek_2022-05-26_17-23	Peek_2022-05-26_17-31

3. Previously, the loading spinner was added to the bottom of the page only when the next page of results was being loaded. This causes the dropdown scroll position to jump a little when the spinner is shown. Now, the spinner is always at the bottom of the list, but it's not visible until the page is loading, which prevents the jump:

Before	After
Peek_2022-05-26_17-28	Peek_2022-05-26_17-33

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

Related to #356327 (closed)

changed milestone to %15.1

added Category:Vulnerability Management devopssecure featureenhancement frontend groupthreat insights missed:14.10 missed:15.0 sectionsec typefeature workflowverification labels

assigned to @dftian

Suggested Reviewers (beta)

The individuals below may be good candidates to participate in the review based on various factors.

You can use slash commands in comments to quickly assign /assign_reviewer @user1.

Suggested Reviewers
@pgascouvaillancourt, @dpisek, @markrian, @jivanvl, @kushalpandya

If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".

mentioned in commit 0ee98a35

added 1 commit

• 0ee98a35 - Fix vulnerability report project filter loading icon

Compare with previous version

	1 Warning
	featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart. For more information, see: The Handbook page on merge request types. The definition of done documentation.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
frontend	Coung Ngo (@cngo) (UTC+1, 11 hours ahead of @dftian)	Natalia Tepluhina (@ntepluhina) (UTC+2, 12 hours ahead of @dftian)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

Generated by Danger

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits f4ab4f15 and a5809fac

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	3.46 MB	3.46 MB	-	-0.0 %
mainChunk	1.94 MB	1.94 MB	-	0.0 %

---

Note: We do not have exact data for f4ab4f15. So we have used data from: d60b2e5b.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun the bundle-size-review job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

Please look at the full report for more details

---

Read more about how this report works.

Generated by Danger

Allure report

allure-report-publisher generated test report!

review-qa-blocking: test report for a5809fac

expand test summary

+-------------------------------------------------------------------+
|                          suites summary                           |
+----------------------+--------+--------+---------+-------+--------+
|                      | passed | failed | skipped | flaky | result |
+----------------------+--------+--------+---------+-------+--------+
| Plan                 | 41     | 0      | 1       | 3     | ❗     |
| Create               | 22     | 0      | 3       | 7     | ❗     |
| Manage               | 36     | 0      | 2       | 3     | ❗     |
| Verify               | 12     | 0      | 1       | 2     | ❗     |
| Protect              | 2      | 0      | 0       | 2     | ❗     |
| Package              | 0      | 0      | 1       | 0     | ➖     |
| Configure            | 0      | 0      | 1       | 0     | ➖     |
| Version sanity check | 0      | 0      | 1       | 0     | ➖     |
+----------------------+--------+--------+---------+-------+--------+
| Total                | 113    | 0      | 10      | 17    | ❗     |
+----------------------+--------+--------+---------+-------+--------+

added workflowin review label and removed workflowverification label

added 3 commits

• ef86e9b7 - Use backend to send security training status instead of using GraphQL
• 2c672342 - Address MR feedback
• 599fd4b7 - More MR feedback

Compare with previous version

mentioned in commit 805b9b4d

added 145 commits

• 599fd4b7...631c2c82 - 144 commits from branch master
• 805b9b4d - Fix vulnerability report project filter loading icon

Compare with previous version

mentioned in commit 241dd15f

added 1 commit

• 241dd15f - Fix vulnerability report project filter loading icon

Compare with previous version

mentioned in commit 3972110a

added 1 commit

• 3972110a - Fix vulnerability report project filter loading icon

Compare with previous version

marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

mentioned in commit 0034bfae

added 1 commit

• 0034bfae - Fix vulnerability report project filter loading icon

Compare with previous version