Skip to content
Snippets Groups Projects

Add audit events for merge request settings

Merged Harsimar Sandhu requested to merge 355805-merge-request-settings-audit-events into master
All threads resolved!

What does this MR do and why?

Captures audit events for following settings

  • Merge commit message template (this is part of Part 1 #301124 (closed) so we can skip this in Part 2)
  • Squash commit message template
  • Default description template for merge requests
  • Status checks added / edited / deleted

Screenshots or screen recordings

Screenshot_2022-04-26_at_12.30.47_AM

Squash options: Screenshot_2022-04-26_at_1.23.05_AM

How to set up and validate locally

  1. Run GDK
  2. Go to Projects Settings -> General and Expand Merge requests.
  3. Add, Edit, Delete Status check, Squash commit message template, Default description template for merge requests, Default description template for merge requests
  4. Check audit events (admin/audit_events or project//-/audit_events) for every action (add, edit, delete)

Related to #355805 (closed)

Edited by Harsimar Sandhu

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Alexandru Croitor
  • Alexandru Croitor removed review request for @acroitor

    removed review request for @acroitor

  • Harsimar Sandhu added 444 commits

    added 444 commits

    Compare with previous version

  • added 1 commit

    • 43ca24eb - Refactor test cases and make shared context

    Compare with previous version

  • Harsimar Sandhu added 351 commits

    added 351 commits

    Compare with previous version

  • Suggested Reviewers (beta)

    This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".

    The individuals below may be good candidates to participate in the review based on various factors.

    After you review all recommendations, please assign reviewers manually, as this is not done automatically.

    You can use slash commands in comments to quickly assign /assign_reviewer @user1.

    Reviewers
    @tancnle, @stanhu, @mayra-cabrera, @huzaifaiftikhar1, @alexives

    If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

    Automatically generated by Suggested Reviewers Bot

  • requested review from @huzaifaiftikhar1

  • Harsimar Sandhu changed milestone to %15.0

    changed milestone to %15.0

  • Harsimar Sandhu added 11 commits

    added 11 commits

    Compare with previous version

  • Suggested Reviewers (beta)

    This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".

    The individuals below may be good candidates to participate in the review based on various factors.

    After you review all recommendations, please assign reviewers manually, as this is not done automatically.

    You can use slash commands in comments to quickly assign /assign_reviewer @user1.

    Reviewers
    @stanhu, @tancnle, @huzaifaiftikhar1, @jboyson, @mayra-cabrera

    If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

    Automatically generated by Suggested Reviewers Bot

  • Huzaifa Iftikhar
  • Huzaifa Iftikhar
  • Huzaifa Iftikhar
  • Huzaifa Iftikhar
  • Huzaifa Iftikhar removed review request for @huzaifaiftikhar1

    removed review request for @huzaifaiftikhar1

  • Harsimar Sandhu added 119 commits

    added 119 commits

    Compare with previous version

  • Suggested Reviewers (beta)

    This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".

    The individuals below may be good candidates to participate in the review based on various factors.

    After you review all recommendations, please assign reviewers manually, as this is not done automatically.

    You can use slash commands in comments to quickly assign /assign_reviewer @user1.

    Reviewers
    @stanhu, @tancnle, @jboyson, @alexives, @ohoral

    If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

    Automatically generated by Suggested Reviewers Bot

  • added 1 commit

    • 80bf98f3 - Add details assertions in specs

    Compare with previous version

  • Suggested Reviewers (beta)

    This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".

    The individuals below may be good candidates to participate in the review based on various factors.

    After you review all recommendations, please assign reviewers manually, as this is not done automatically.

    You can use slash commands in comments to quickly assign /assign_reviewer @user1.

    Reviewers
    @stanhu, @tancnle, @jboyson, @alexives, @ohoral

    If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

    Automatically generated by Suggested Reviewers Bot

  • requested review from @huzaifaiftikhar1

  • Harsimar Sandhu changed the description

    changed the description

  • Huzaifa Iftikhar removed review request for @huzaifaiftikhar1

    removed review request for @huzaifaiftikhar1

  • added 1 commit

    • 5cc3bb01 - Apply 2 suggestion(s) to 2 file(s)

    Compare with previous version

  • Suggested Reviewers (beta)

    This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".

    The individuals below may be good candidates to participate in the review based on various factors.

    After you review all recommendations, please assign reviewers manually, as this is not done automatically.

    You can use slash commands in comments to quickly assign /assign_reviewer @user1.

    Reviewers
    @stanhu, @tancnle, @jboyson, @alexives, @ohoral

    If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

    Automatically generated by Suggested Reviewers Bot

  • Harsimar Sandhu added 249 commits

    added 249 commits

    Compare with previous version

  • Suggested Reviewers (beta)

    This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".

    The individuals below may be good candidates to participate in the review based on various factors.

    After you review all recommendations, please assign reviewers manually, as this is not done automatically.

    You can use slash commands in comments to quickly assign /assign_reviewer @user1.

    Reviewers
    @stanhu, @tancnle, @jboyson, @alexives, @ohoral

    If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

    Automatically generated by Suggested Reviewers Bot

    • Contributor
      Resolved by Huzaifa Iftikhar

      @harsimarsandhu I'm looking at the picture in the issue description - is it possible to add more detail to the status check messages to indicate which status check was changed? If a project has more than one status check, it would be hard to understand the details of what the change was.

  • Harsimar Sandhu changed the description

    changed the description

  • added 1 commit

    • a19b9792 - Add name in status check audit

    Compare with previous version

  • Suggested Reviewers (beta)

    This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".

    The individuals below may be good candidates to participate in the review based on various factors.

    After you review all recommendations, please assign reviewers manually, as this is not done automatically.

    You can use slash commands in comments to quickly assign /assign_reviewer @user1.

    Reviewers
    @stanhu, @tancnle, @jboyson, @alexives, @ohoral

    If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

    Automatically generated by Suggested Reviewers Bot

  • requested review from @huzaifaiftikhar1

  • Huzaifa Iftikhar approved this merge request

    approved this merge request

  • Huzaifa Iftikhar requested review from @alipniagov and removed review request for @huzaifaiftikhar1

    requested review from @alipniagov and removed review request for @huzaifaiftikhar1

  • :wave: @huzaifaiftikhar1, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • Suggested Reviewers (beta)

    This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".

    The individuals below may be good candidates to participate in the review based on various factors.

    After you review all recommendations, please assign reviewers manually, as this is not done automatically.

    You can use slash commands in comments to quickly assign /assign_reviewer @user1.

    Reviewers
    @stanhu, @tancnle, @jboyson, @alexives, @ohoral

    If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

    Automatically generated by Suggested Reviewers Bot

  • Aleksei Lipniagov
  • added 1 commit

    • 03dc7bff - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Suggested Reviewers (beta)

    This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".

    The individuals below may be good candidates to participate in the review based on various factors.

    After you review all recommendations, please assign reviewers manually, as this is not done automatically.

    You can use slash commands in comments to quickly assign /assign_reviewer @user1.

    Reviewers
    @stanhu, @tancnle, @jboyson, @alexives, @ohoral

    If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

    Automatically generated by Suggested Reviewers Bot

  • Aleksei Lipniagov removed review request for @alipniagov

    removed review request for @alipniagov

  • added 1 commit

    • ec2de8d3 - Apply review feedback suggestions

    Compare with previous version

  • Suggested Reviewers (beta)

    This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".

    The individuals below may be good candidates to participate in the review based on various factors.

    After you review all recommendations, please assign reviewers manually, as this is not done automatically.

    You can use slash commands in comments to quickly assign /assign_reviewer @user1.

    Reviewers
    @qmnguyen0711, @mkaeppler, @aishbuilds, @alipniagov, @rob.hunt

    If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

    Automatically generated by Suggested Reviewers Bot

  • Harsimar Sandhu added 517 commits

    added 517 commits

    • ec2de8d3...87105f54 - 506 commits from branch master
    • 2e171822 - Add audit events for merge request settings
    • 9cae541c - Refactor test cases and callbacks
    • 013a3a83 - Refactor test cases and make shared context
    • e6d4aa88 - Apply review feedback suggestions
    • af837b3d - Refactor update service spec
    • 56ac60fc - Add details assertions in specs
    • 1ebe5c19 - Apply 2 suggestion(s) to 2 file(s)
    • 4dbbe8c6 - Rubocop lint fix
    • a3501259 - Add name in status check audit
    • 320d9add - Apply 1 suggestion(s) to 1 file(s)
    • df0f6207 - Apply review feedback suggestions

    Compare with previous version

  • Suggested Reviewers (beta)

    This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".

    The individuals below may be good candidates to participate in the review based on various factors.

    After you review all recommendations, please assign reviewers manually, as this is not done automatically.

    You can use slash commands in comments to quickly assign /assign_reviewer @user1.

    Reviewers
    @qmnguyen0711, @mkaeppler, @aishbuilds, @alipniagov, @rob.hunt

    If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

    Automatically generated by Suggested Reviewers Bot

  • Harsimar Sandhu requested review from @alipniagov

    requested review from @alipniagov

  • added 1 commit

    • 0528ba57 - Make audit event message more user friendly

    Compare with previous version

  • Suggested Reviewers (beta)

    This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".

    The individuals below may be good candidates to participate in the review based on various factors.

    After you review all recommendations, please assign reviewers manually, as this is not done automatically.

    You can use slash commands in comments to quickly assign /assign_reviewer @user1.

    Reviewers
    @qmnguyen0711, @mkaeppler, @aishbuilds, @alipniagov, @rob.hunt

    If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

    Automatically generated by Suggested Reviewers Bot

  • Same for Merge commit template, the "from" without "to" in case of default looks confusing IMO:

    Screenshot_2022-04-25_at_18.02.00

    Edited by Aleksei Lipniagov
    • Resolved by Aleksei Lipniagov

      Nitpick, but because we specify all-branches/particular branch in edit, we could also consider specifying it in the creation event:

      Screenshot_2022-04-25_at_18.15.06

      e.g. Added NewQA status check with all branches or Added NewQA status check with protected branch main...

  • Aleksei Lipniagov removed review request for @alipniagov

    removed review request for @alipniagov

  • Harsimar Sandhu changed the description

    changed the description

  • added 1 commit

    • 7ac8e089 - t push # This is the 1st commit message:

    Compare with previous version

  • Suggested Reviewers (beta)

    This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".

    The individuals below may be good candidates to participate in the review based on various factors.

    After you review all recommendations, please assign reviewers manually, as this is not done automatically.

    You can use slash commands in comments to quickly assign /assign_reviewer @user1.

    Reviewers
    @toon, @tancnle, @stanhu, @reprazent, @jameslopez

    If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

    Automatically generated by Suggested Reviewers Bot

  • added 1 commit

    • 28074264 - Humanize squash option audit and status check branch creation

    Compare with previous version

  • Suggested Reviewers (beta)

    This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".

    The individuals below may be good candidates to participate in the review based on various factors.

    After you review all recommendations, please assign reviewers manually, as this is not done automatically.

    You can use slash commands in comments to quickly assign /assign_reviewer @user1.

    Reviewers
    @toon, @tancnle, @stanhu, @reprazent, @jameslopez

    If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

    Automatically generated by Suggested Reviewers Bot

  • Harsimar Sandhu changed the description

    changed the description

  • added 1 commit

    • b7ceddaf - Humanize squash option audit and status check branch creation

    Compare with previous version

  • Suggested Reviewers (beta)

    This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".

    The individuals below may be good candidates to participate in the review based on various factors.

    After you review all recommendations, please assign reviewers manually, as this is not done automatically.

    You can use slash commands in comments to quickly assign /assign_reviewer @user1.

    Reviewers
    @toon, @tancnle, @stanhu, @reprazent, @jameslopez

    If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

    Automatically generated by Suggested Reviewers Bot

  • Harsimar Sandhu mentioned in issue #360495

    mentioned in issue #360495

  • Harsimar Sandhu requested review from @alipniagov

    requested review from @alipniagov

  • Aleksei Lipniagov
  • added 1 commit

    • 413aa20f - Apply 3 suggestion(s) to 1 file(s)

    Compare with previous version

  • Suggested Reviewers (beta)

    This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".

    The individuals below may be good candidates to participate in the review based on various factors.

    After you review all recommendations, please assign reviewers manually, as this is not done automatically.

    You can use slash commands in comments to quickly assign /assign_reviewer @user1.

    Reviewers
    @toon, @tancnle, @stanhu, @reprazent, @jameslopez

    If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

    Automatically generated by Suggested Reviewers Bot

  • Hm, that looks like our web preview bug:
    Screenshot_2022-04-26_at_12.04.01

    In diff view, it shows that spaces are missing between then and the quote while they're in place in the actual code :thinking:

    UPD: ok, now it's fine. Probably cache or delayed replication.

    Edited by Aleksei Lipniagov
  • Aleksei Lipniagov resolved all threads

    resolved all threads

  • Aleksei Lipniagov approved this merge request

    approved this merge request

  • Aleksei Lipniagov enabled an automatic merge when the pipeline for dab37020 succeeds

    enabled an automatic merge when the pipeline for dab37020 succeeds

  • mentioned in commit 7c30c5e9

  • added workflowstaging label and removed workflowcanary label

  • Michael Becker mentioned in commit cdee6003

    mentioned in commit cdee6003

  • Michael Becker mentioned in commit 969a9b74

    mentioned in commit 969a9b74

  • Michael Becker mentioned in commit a0028de4

    mentioned in commit a0028de4

  • Michael Becker mentioned in commit 34937a06

    mentioned in commit 34937a06

  • Michael Becker mentioned in commit 01dbd720

    mentioned in commit 01dbd720

  • Michael Becker mentioned in commit 905a382f

    mentioned in commit 905a382f

  • Michael Becker mentioned in commit 1350de73

    mentioned in commit 1350de73

  • Michael Becker mentioned in merge request !115501 (merged)

    mentioned in merge request !115501 (merged)

  • Michael Becker mentioned in merge request !115501 (merged)

    mentioned in merge request !115501 (merged)

  • Hitesh Raghuvanshi mentioned in merge request !114991 (merged)

    mentioned in merge request !114991 (merged)

  • Please register or sign in to reply
    Loading