Add audit events for merge request settings
What does this MR do and why?
Captures audit events for following settings
- Merge commit message template (this is part of Part 1 #301124 (closed) so we can skip this in Part 2)
- Squash commit message template
- Default description template for merge requests
- Status checks added / edited / deleted
Screenshots or screen recordings
How to set up and validate locally
- Run GDK
- Go to Projects Settings -> General and Expand Merge requests.
- Add, Edit, Delete Status check, Squash commit message template, Default description template for merge requests, Default description template for merge requests
- Check audit events (admin/audit_events or project//-/audit_events) for every action (add, edit, delete)
Related to #355805 (closed)
Merge request reports
Activity
changed milestone to %14.10
assigned to @harsimarsandhu
4 Warnings This merge request is quite big (560 lines changed), please consider splitting it into multiple merge requests. b7ceddaf: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. e6d4aa88: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 9cae541c: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. If needed, you can retry the
danger-review
job that generated this comment.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Catalin Irimie ( @cat
) (UTC+1)Peter Leitzen ( @splattael
) (UTC+2)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Dangeradded 29 commits
-
a34249e9...ef201a54 - 28 commits from branch
master
- 4208f963 - Add audit events for merge request settings
-
a34249e9...ef201a54 - 28 commits from branch
Allure report
allure-report-publisher
generated test report!review-qa-smoke:
test report
review-qa-reliable: test report
review-qa-blocking: test report
package-and-qa: test reportpackage-and-qa:
test report for 57d0a2c8+---------------------------------------------------------------------------+ | suites summary | +------------------------------+--------+--------+---------+-------+--------+ | | passed | failed | skipped | flaky | result | +------------------------------+--------+--------+---------+-------+--------+ | Manage | 336 | 0 | 24 | 0 | ✅ | | Create | 537 | 0 | 32 | 0 | ✅ | | Plan | 205 | 0 | 1 | 0 | ✅ | | Fulfillment | 9 | 0 | 40 | 0 | ✅ | | Release | 19 | 0 | 0 | 0 | ✅ | | Verify | 135 | 0 | 12 | 0 | ✅ | | Secure | 64 | 0 | 7 | 0 | ✅ | | Configure | 1 | 0 | 12 | 0 | ✅ | | Service ping disabled | 1 | 0 | 0 | 0 | ✅ | | Package | 135 | 2 | 15 | 0 | ❌ | | Version sanity check | 0 | 0 | 4 | 0 | ➖ | | Protect | 12 | 0 | 0 | 0 | ✅ | | SSH keys support | 6 | 0 | 0 | 0 | ✅ | | Enablement:Search | 9 | 0 | 1 | 0 | ✅ | | Package Registry | 24 | 0 | 0 | 0 | ✅ | | Service ping default enabled | 3 | 0 | 0 | 0 | ✅ | | API basics | 8 | 0 | 0 | 0 | ✅ | | Non-devops | 4 | 0 | 0 | 0 | ✅ | +------------------------------+--------+--------+---------+-------+--------+ | Total | 1508 | 2 | 148 | 0 | ❌ | +------------------------------+--------+--------+---------+-------+--------+
review-qa-blocking:
test report for 413aa20f+-------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+--------+ | | passed | failed | skipped | flaky | result | +----------------------+--------+--------+---------+-------+--------+ | Plan | 41 | 0 | 1 | 1 | ❗ | | Verify | 12 | 0 | 1 | 4 | ❗ | | Package | 6 | 0 | 1 | 6 | ❗ | | Create | 18 | 0 | 2 | 1 | ❗ | | Manage | 28 | 0 | 2 | 14 | ❗ | | Configure | 0 | 0 | 1 | 0 | ➖ | | Version sanity check | 0 | 0 | 1 | 0 | ➖ | | Protect | 3 | 0 | 0 | 0 | ✅ | +----------------------+--------+--------+---------+-------+--------+ | Total | 108 | 0 | 9 | 26 | ❗ | +----------------------+--------+--------+---------+-------+--------+
added 325 commits
-
257f8ea7...a0491ce9 - 324 commits from branch
master
- ed2f4fc6 - Add audit events for merge request settings
-
257f8ea7...a0491ce9 - 324 commits from branch
added 5 commits
-
262e01ff...898599bd - 4 commits from branch
master
- 5f5da2b2 - Add audit events for merge request settings
-
262e01ff...898599bd - 4 commits from branch
- Resolved by Aleksei Lipniagov
@acroitor could you please review this MR
?
requested review from @acroitor
- Resolved by Huzaifa Iftikhar
- Resolved by Huzaifa Iftikhar
- Resolved by Huzaifa Iftikhar
- Resolved by Harsimar Sandhu
- Resolved by Harsimar Sandhu
- Resolved by Harsimar Sandhu
- Resolved by Harsimar Sandhu
- Resolved by Harsimar Sandhu
- Resolved by Harsimar Sandhu
removed review request for @acroitor
added 444 commits
-
e40cb2e2...7121c173 - 442 commits from branch
master
- 5930f76c - Add audit events for merge request settings
- 580c1ade - Refactor test cases and callbacks
-
e40cb2e2...7121c173 - 442 commits from branch
added 351 commits
-
43ca24eb...46b38736 - 348 commits from branch
master
- c9f683f4 - Add audit events for merge request settings
- 8178e0cd - Refactor test cases and callbacks
- 4d9f9cea - Refactor test cases and make shared context
Toggle commit list-
43ca24eb...46b38736 - 348 commits from branch
Suggested Reviewers (beta)
This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".
The individuals below may be good candidates to participate in the review based on various factors.
After you review all recommendations, please assign reviewers manually, as this is not done automatically.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Reviewers @tancnle
,@stanhu
,@mayra-cabrera
,@huzaifaiftikhar1
,@alexives
If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot
requested review from @huzaifaiftikhar1
changed milestone to %15.0
added 11 commits
-
4d9f9cea...9d5c0040 - 8 commits from branch
master
- 70bd996b - Add audit events for merge request settings
- 6aa474f6 - Refactor test cases and callbacks
- bbc1e4a2 - Refactor test cases and make shared context
Toggle commit list-
4d9f9cea...9d5c0040 - 8 commits from branch
Suggested Reviewers (beta)
This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".
The individuals below may be good candidates to participate in the review based on various factors.
After you review all recommendations, please assign reviewers manually, as this is not done automatically.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Reviewers @stanhu
,@tancnle
,@huzaifaiftikhar1
,@jboyson
,@mayra-cabrera
If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot
- Resolved by Huzaifa Iftikhar
- Resolved by Huzaifa Iftikhar
- Resolved by Huzaifa Iftikhar
- Resolved by Huzaifa Iftikhar
- Resolved by Huzaifa Iftikhar
- Resolved by Huzaifa Iftikhar
- Resolved by Huzaifa Iftikhar
- Resolved by Huzaifa Iftikhar
- Resolved by Huzaifa Iftikhar
- Resolved by Huzaifa Iftikhar
- Resolved by Huzaifa Iftikhar
- Resolved by Huzaifa Iftikhar
- Resolved by Huzaifa Iftikhar
- Resolved by Huzaifa Iftikhar
- Resolved by Huzaifa Iftikhar
- Resolved by Huzaifa Iftikhar
- Resolved by Huzaifa Iftikhar
- Resolved by Harsimar Sandhu
removed workflowin dev label
removed review request for @huzaifaiftikhar1
mentioned in issue gitlab-com/www-gitlab-com#13148 (closed)
added 119 commits
Toggle commit listSuggested Reviewers (beta)
This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".
The individuals below may be good candidates to participate in the review based on various factors.
After you review all recommendations, please assign reviewers manually, as this is not done automatically.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Reviewers @stanhu
,@tancnle
,@jboyson
,@alexives
,@ohoral
If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot
Suggested Reviewers (beta)
This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".
The individuals below may be good candidates to participate in the review based on various factors.
After you review all recommendations, please assign reviewers manually, as this is not done automatically.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Reviewers @stanhu
,@tancnle
,@jboyson
,@alexives
,@ohoral
If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot
requested review from @huzaifaiftikhar1
- Resolved by Harsimar Sandhu
- Resolved by Harsimar Sandhu
removed review request for @huzaifaiftikhar1
Suggested Reviewers (beta)
This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".
The individuals below may be good candidates to participate in the review based on various factors.
After you review all recommendations, please assign reviewers manually, as this is not done automatically.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Reviewers @stanhu
,@tancnle
,@jboyson
,@alexives
,@ohoral
If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot
added 249 commits
-
5cc3bb01...b02f851a - 241 commits from branch
master
- 31735007 - Add audit events for merge request settings
- 7928685c - Refactor test cases and callbacks
- c91562c6 - Refactor test cases and make shared context
- cdd33a6a - Apply review feedback suggestions
- cf7c68ce - Refactor update service spec
- ab63ee79 - Add details assertions in specs
- 315d93a6 - Apply 2 suggestion(s) to 2 file(s)
- 57d0a2c8 - Rubocop lint fix
Toggle commit list-
5cc3bb01...b02f851a - 241 commits from branch
Suggested Reviewers (beta)
This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".
The individuals below may be good candidates to participate in the review based on various factors.
After you review all recommendations, please assign reviewers manually, as this is not done automatically.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Reviewers @stanhu
,@tancnle
,@jboyson
,@alexives
,@ohoral
If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot
- Resolved by Huzaifa Iftikhar
@harsimarsandhu I'm looking at the picture in the issue description - is it possible to add more detail to the status check messages to indicate which status check was changed? If a project has more than one status check, it would be hard to understand the details of what the change was.
Suggested Reviewers (beta)
This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".
The individuals below may be good candidates to participate in the review based on various factors.
After you review all recommendations, please assign reviewers manually, as this is not done automatically.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Reviewers @stanhu
,@tancnle
,@jboyson
,@alexives
,@ohoral
If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot
requested review from @huzaifaiftikhar1
requested review from @alipniagov and removed review request for @huzaifaiftikhar1
@huzaifaiftikhar1
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
Suggested Reviewers (beta)
This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".
The individuals below may be good candidates to participate in the review based on various factors.
After you review all recommendations, please assign reviewers manually, as this is not done automatically.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Reviewers @stanhu
,@tancnle
,@jboyson
,@alexives
,@ohoral
If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot
- Resolved by Aleksei Lipniagov
- Resolved by Harsimar Sandhu
- Resolved by Aleksei Lipniagov
- Resolved by Aleksei Lipniagov
- Resolved by Aleksei Lipniagov
- Resolved by Aleksei Lipniagov
- Resolved by Aleksei Lipniagov
Suggested Reviewers (beta)
This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".
The individuals below may be good candidates to participate in the review based on various factors.
After you review all recommendations, please assign reviewers manually, as this is not done automatically.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Reviewers @stanhu
,@tancnle
,@jboyson
,@alexives
,@ohoral
If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot
removed review request for @alipniagov
Suggested Reviewers (beta)
This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".
The individuals below may be good candidates to participate in the review based on various factors.
After you review all recommendations, please assign reviewers manually, as this is not done automatically.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Reviewers @qmnguyen0711
,@mkaeppler
,@aishbuilds
,@alipniagov
,@rob.hunt
If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot
added 517 commits
-
ec2de8d3...87105f54 - 506 commits from branch
master
- 2e171822 - Add audit events for merge request settings
- 9cae541c - Refactor test cases and callbacks
- 013a3a83 - Refactor test cases and make shared context
- e6d4aa88 - Apply review feedback suggestions
- af837b3d - Refactor update service spec
- 56ac60fc - Add details assertions in specs
- 1ebe5c19 - Apply 2 suggestion(s) to 2 file(s)
- 4dbbe8c6 - Rubocop lint fix
- a3501259 - Add name in status check audit
- 320d9add - Apply 1 suggestion(s) to 1 file(s)
- df0f6207 - Apply review feedback suggestions
Toggle commit list-
ec2de8d3...87105f54 - 506 commits from branch
Suggested Reviewers (beta)
This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".
The individuals below may be good candidates to participate in the review based on various factors.
After you review all recommendations, please assign reviewers manually, as this is not done automatically.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Reviewers @qmnguyen0711
,@mkaeppler
,@aishbuilds
,@alipniagov
,@rob.hunt
If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot
requested review from @alipniagov
- Resolved by Aleksei Lipniagov
Suggested Reviewers (beta)
This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".
The individuals below may be good candidates to participate in the review based on various factors.
After you review all recommendations, please assign reviewers manually, as this is not done automatically.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Reviewers @qmnguyen0711
,@mkaeppler
,@aishbuilds
,@alipniagov
,@rob.hunt
If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot
- Resolved by Aleksei Lipniagov
@harsimarsandhu would user be able to link what is what there? :
In the settings, it is not clear what is "always" and what is "default_on"
Edited by Aleksei Lipniagov
- Resolved by Aleksei Lipniagov
I left the field empty, sent the form, and the audit message is confusing "from ..." without "to" (although it works)
Maybe we should say something like "to default..."?
Edited by Aleksei Lipniagov
- Edited by Aleksei Lipniagov
- Resolved by Aleksei Lipniagov
Maybe it's not something we should address right now, but just FYI if we put a big description it looks off:
We may want to have field limit and/or cut the text in the audit events (...)
Feel free to open follow-up issues unless it's an urgent issue from your domain's perspective.
Edited by Aleksei Lipniagov
- Resolved by Aleksei Lipniagov
removed review request for @alipniagov
Suggested Reviewers (beta)
This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".
The individuals below may be good candidates to participate in the review based on various factors.
After you review all recommendations, please assign reviewers manually, as this is not done automatically.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Reviewers @toon
,@tancnle
,@stanhu
,@reprazent
,@jameslopez
If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot
added 1 commit
- 28074264 - Humanize squash option audit and status check branch creation
Suggested Reviewers (beta)
This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".
The individuals below may be good candidates to participate in the review based on various factors.
After you review all recommendations, please assign reviewers manually, as this is not done automatically.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Reviewers @toon
,@tancnle
,@stanhu
,@reprazent
,@jameslopez
If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot
added 1 commit
- b7ceddaf - Humanize squash option audit and status check branch creation
Suggested Reviewers (beta)
This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".
The individuals below may be good candidates to participate in the review based on various factors.
After you review all recommendations, please assign reviewers manually, as this is not done automatically.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Reviewers @toon
,@tancnle
,@stanhu
,@reprazent
,@jameslopez
If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot
mentioned in issue #360495
requested review from @alipniagov
- Resolved by Aleksei Lipniagov
- Resolved by Aleksei Lipniagov
- Resolved by Aleksei Lipniagov
- Resolved by Aleksei Lipniagov
Suggested Reviewers (beta)
This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".
The individuals below may be good candidates to participate in the review based on various factors.
After you review all recommendations, please assign reviewers manually, as this is not done automatically.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Reviewers @toon
,@tancnle
,@stanhu
,@reprazent
,@jameslopez
If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot
Hm, that looks like our web preview bug:
In diff view, it shows that spaces are missing between
then
and the quote while they're in place in the actual codeUPD: ok, now it's fine. Probably cache or delayed replication.
Edited by Aleksei Lipniagovenabled an automatic merge when the pipeline for dab37020 succeeds
mentioned in commit 7c30c5e9
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in merge request gitlab-com/www-gitlab-com!102366 (merged)
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1040 (merged)
mentioned in commit cdee6003
mentioned in commit 969a9b74
mentioned in commit a0028de4
mentioned in commit 34937a06
mentioned in commit 01dbd720
mentioned in commit 905a382f
mentioned in commit 1350de73
mentioned in merge request !115501 (merged)
mentioned in merge request !115501 (merged)
mentioned in merge request !114991 (merged)