Revert "Merge branch '337496-link-by-name-not-id-pipelines' into 'master'"
What does this MR do and why?
This MR reverts the changes in Link pipeline by their name/commit name rather ... (#337496 - closed)
This change has caused some confusion amongst internal users and we worry that it will do the same for external ones when released.
Slack thread: https://gitlab.slack.com/archives/CETG54GQ0/p1645105866979929
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Visit the pipelines table
- Click on the pipeline ID, it should take you to the pipeline
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @samdbeckham
- A deleted user
added frontend label
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Tristan Read ( @tristan.read
) (UTC+13, 13 hours ahead of@samdbeckham
)Ezekiel Kigbo ( @ekigbo
) (UTC+11, 11 hours ahead of@samdbeckham
)test Quality for spec/features/*
Tiffany Rea ( @treagitlab
) (UTC-8, 8 hours behind@samdbeckham
)Maintainer review is optional for test Quality for spec/features/*
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 12007969 and 7c2eca58
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.69 MB 3.69 MB - -0.0 % mainChunk 2.3 MB 2.3 MB - 0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
Dangermarked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
added Pick into 14.8 label
changed milestone to %14.8
removed Verify candidate label
removed auto updated label
removed workflowproduction label
- Resolved by Jose Ivan Vargas
@pburdette could you review this please and pass it on to @jivanvl once you're happy?
See the discussion on slack for why we're doing this: https://gitlab.slack.com/archives/CETG54GQ0/p1645105866979929
requested review from @pburdette
Allure report
allure-report-publisher
generated test report for 7c2eca58!review-qa-reliable:
test report
review-qa-smoke: test report@pburdette
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
requested review from @jivanvl and removed review request for @pburdette
mentioned in commit 884ecd76
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added severity3 label
@samdbeckham This merge request could not automatically be picked into
14-8-stable-ee
for14.8.1-ee
and will need manual intervention.Create a new merge request targeting the
14-8-stable-ee-patch-1
branch in order to have this MR included in !81398 (merged).Please follow the Process for Developers.
@samdbeckham No need to do anything, it was a hiccup
removed Pick into 14.8 label
mentioned in merge request !81398 (merged)
added Pick into 14.8 label
picked the changes into the branch
14-8-stable-ee-patch-1
with commit 1534e200Automatically picked into !81398 (merged), will merge into
14-8-stable-ee
ready for14.8.1-ee
.removed Pick into 14.8 label
mentioned in commit 1534e200
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label