Skip to content
Snippets Groups Projects

Add a user overage modal

Merged Diana Zubova requested to merge dz/348486-add-second-modal into master

What does this MR do and why?

Introduce a feature flag overage_members_modal and show a modal confirmation window when adding new members to a group. The modal will be shown if the group has a subscription and adding a new member to it will cause overage.

This is a first part of implementing this modal, currently we show the overage modal on every addition if the FF is turned on. There is be a backend follow-up MR to add a proper check.

Step Status
Introduce a FF and a modal on FE :point_right: you are here
Add logic to when we show overage modal and calculate the amount of users for overage !78287 (merged) workflowin dev

Related to #348486 (closed)

Screenshots or screen recordings

Screen_Recording_2022-02-15_at_19.34.14

How to set up and validate locally

  1. If the feature flag is not enabled user won't see an overage modal

  2. Enable the overage modal

    Feature.enable(:overage_members_modal)
  3. Visit any group page, then Group Information -> Members http://localhost:3000/groups/<your-group>/-/group_members.

  4. Click the Invite members button

  5. Add a user and click Invite.

  6. Check the modal.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Diana Zubova

Merge request reports

Merged results pipeline #472993957 passed with warnings

Pipeline: GitLab

#473007861

    Pipeline: omnibus-gitlab-mirror

    #473008472

      Pipeline: omnibus-gitlab-mirror

      #473008491

        Merged results pipeline passed with warnings for 3736b9ed

        Test coverage 87.00% (-1.44%) from 2 jobs

        Merged by Natalia TepluhinaNatalia Tepluhina 3 years ago (Feb 17, 2022 12:07pm UTC)

        Merge details

        Pipeline #473240511 passed

        Pipeline passed for cc783c2f on master

        Test coverage 79.01% (-1.44%) from 2 jobs
        8 environments impacted.

        Activity

        Filter activity
        • Approvals
        • Assignees & reviewers
        • Comments (from bots)
        • Comments (from users)
        • Commits & branches
        • Edits
        • Labels
        • Lock status
        • Mentions
        • Merge request status
        • Tracking
        Please register or sign in to reply
        Loading