Add a user overage modal
What does this MR do and why?
Introduce a feature flag overage_members_modal
and show a modal confirmation window when adding new members to a group.
The modal will be shown if the group has a subscription and adding a new member to it will cause overage.
This is a first part of implementing this modal, currently we show the overage modal on every addition if the FF is turned on. There is be a backend follow-up MR to add a proper check.
Step | Status |
---|---|
Introduce a FF and a modal on FE |
![]() |
Add logic to when we show overage modal and calculate the amount of users for overage | !78287 (merged) workflowin dev |
Related to #348486 (closed)
Screenshots or screen recordings
Screen_Recording_2022-02-15_at_19.34.14
How to set up and validate locally
-
If the feature flag is not enabled user won't see an overage modal
-
Enable the overage modal
Feature.enable(:overage_members_modal)
-
Visit any group page, then Group Information -> Members
http://localhost:3000/groups/<your-group>/-/group_members
. -
Click the
Invite members
button -
Add a user and click
Invite
. -
Check the modal.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %14.8
assigned to @dzubova
added grouppurchase [DEPRECATED] label
mentioned in merge request !78128 (closed)
mentioned in merge request !78287 (merged)
3 Warnings This merge request is quite big (656 lines changed), please consider splitting it into multiple merge requests. 85ad800d: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 0ca413ee: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Allison Browne ( @allison.browne
) (UTC-5, 6 hours behind@dzubova
)Markus Koller ( @toupeira
) (UTC+1, same timezone as@dzubova
)frontend Himanshu Kapoor ( @himkp
) (UTC+1, same timezone as@dzubova
)Simon Knox ( @psimyn
) (UTC+11, 10 hours ahead of@dzubova
)test Quality for spec/features/*
Dan Davison ( @ddavison
) (UTC-5, 6 hours behind@dzubova
)Maintainer review is optional for test Quality for spec/features/*
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 1118 commits
-
969ab5e9...d088bff9 - 1117 commits from branch
master
- 3755d4f3 - Add overage confirmation modal
-
969ab5e9...d088bff9 - 1117 commits from branch
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits a8a61c9d and 85ad800d
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent mainChunk 2.29 MB 2.3 MB +4.82 KB 0.2 % average 3.68 MB 3.69 MB +4.3 KB 0.1 %
Note: We do not have exact data for a8a61c9d. So we have used data from: 32d31e9a.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report for 85ad800d!review-qa-smoke:
test report
review-qa-reliable: test report
package-and-qa-ff-enabled: test report
package-and-qa-ff-disabled: test reportmentioned in issue #348486 (closed)
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Natalia Tepluhina
@sheldonled could you please do a frontend review for this MR? TIA- Resolved by Natalia Tepluhina
@shreyasagarwal could you please do a backend review for this MR? TIA
requested review from @chloeliu, @shreyasagarwal, and @sheldonled
- Resolved by Natalia Tepluhina
- Resolved by Chloe Liu
- Resolved by Chloe Liu
- Resolved by Chloe Liu
- Resolved by Chloe Liu
removed review request for @chloeliu
- Resolved by Natalia Tepluhina