Add a modal under feature flag for members invite
What does this MR do and why?
Introduce a feature flag 'overage_members_modal' and show a modal when this FF when adding new members to a group.
The modal will be shown if the group has a subscription and adding a new member to it will cause overage.
This is a first part of implementing this modal, currently the condition is not accounting for case when users added are already members of top level group, there will be a follow-up to iterate on it.
Related to #348486 (closed)
Screenshots or screen recordings
Screen_Recording_2022-01-14_at_13.34.42
How to set up and validate locally
(guess what, we have exactly this case as a placeholder for this section!)
- Enable the invite modal
Feature.enable(:overage_members_modal)
- Visit any group page that has a subscription OR create a new group and buy a premium subscription for one user for it.
- Click the
invite members
button - If the added user will be over the subscription paid amount, the modal will be shown.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %14.7
assigned to @dzubova
added typefeature label
- A deleted user
added backend feature flag frontend labels
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Sean Arnold ( @seanarnold
) (UTC+13, 12 hours ahead of@dzubova
)Nikola Milojevic ( @nmilojevic1
) (UTC+1, same timezone as@dzubova
)frontend Paul Gascou-Vaillancourt ( @pgascouvaillancourt
) (UTC+1, same timezone as@dzubova
)Andrew Fontaine ( @afontaine
) (UTC-5, 6 hours behind@dzubova
)test Quality for spec/features/*
Dan Davison ( @ddavison
) (UTC-5, 6 hours behind@dzubova
)Maintainer review is optional for test Quality for spec/features/*
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 186a28fb and c17263d2
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.66 MB 3.66 MB -5.86 KB -0.2 % mainChunk 2.28 MB 2.28 MB - 0.0 % Significant Growth: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.security.dast_profiles 1.12 MB 1.16 MB +34.91 KB 3.0 % New entry points: 3Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.packages.packages.show 0 Bytes 1.2 MB +1.2 MB 100.0 % pages.projects.packages.packages.index 0 Bytes 1.1 MB +1.1 MB 100.0 % pages.groups.packages.index 0 Bytes 961.36 KB +961.36 KB 100.0 % Significant Reduction: 8Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.trials.create_lead 837.08 KB 126.95 KB -710.12 KB -84.8 % pages.trials.new 836.63 KB 129.88 KB -706.74 KB -84.5 % pages.groups.roadmap.show 2.77 MB 2.32 MB -460.6 KB -16.3 % pages.groups.epics.index 2.77 MB 2.36 MB -413.93 KB -14.6 % pages.admin.labels.edit 143.74 KB 11.33 KB -132.41 KB -92.1 % pages.projects.labels.edit 956.19 KB 823.78 KB -132.41 KB -13.8 % pages.groups.labels.edit 156.6 KB 24.19 KB -132.41 KB -84.6 % pages.profiles.slacks 224.68 KB 206.65 KB -18.03 KB -8.0 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@dmishunov
,@justin_ho
,@mikegreiling
or@nmezzopera
) for review, if you are unsure about the size increase.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report for c17263d2!review-qa-smoke:
test report
review-qa-reliable: test report
package-and-qa-ff-enabled: test report
package-and-qa-ff-disabled: test reportWow, how didn't I notice
Sure, you are right @aalakkad Added your suggestions, could you please take another look?
Hey @dzubova
overall, changes look great -- I left you a few minor comments, let me know what you think@jhyson thank you very much for the review, as always with a lot of attention to details :) Addressed, back to you
Thanks for the updates @dzubova
I've left you just a couple of very minor points. I think they have a straight-forward resolution so I'll approve as-is and you can pass to the maintainer after you've had a look :)
requested review from @esybrant
- Resolved by Emily Sybrant
@esybrant could you please do a UX review for this MR?
mentioned in issue #348486 (closed)
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
added 736 commits
-
87070917...39b7314a - 735 commits from branch
master
- 2a168204 - Add overage members modal
-
87070917...39b7314a - 735 commits from branch
- Resolved by Josianne Hyson
- Resolved by Ammar Alakkad
removed review request for @aalakkad
- Resolved by Ammar Alakkad
- Resolved by Ammar Alakkad
requested review from @aalakkad
The
package-and-qa-ff-disabled
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/448427025 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/448445515 downstream.The
package-and-qa-ff-enabled
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/448427025 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/448445525 downstream.The
qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/448445525 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/448466602 downstream.The
qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/448445515 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/448471344 downstream.The
gitlab-qa
downstream pipeline failed! .The
gitlab-qa
downstream pipeline failed! .The
package-and-qa-ff-disabled
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/448540051 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/448551747 downstream.
removed review request for @esybrant
@esybrant
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links: