Skip to content
Snippets Groups Projects

Add a modal under feature flag for members invite

Closed Diana Zubova requested to merge dz/348486-additional-charge-users-modal into master

What does this MR do and why?

Introduce a feature flag 'overage_members_modal' and show a modal when this FF when adding new members to a group.

The modal will be shown if the group has a subscription and adding a new member to it will cause overage.

This is a first part of implementing this modal, currently the condition is not accounting for case when users added are already members of top level group, there will be a follow-up to iterate on it.

Related to #348486 (closed)

Screenshots or screen recordings

Screen_Recording_2022-01-14_at_13.34.42

Screenshot_2022-01-13_at_17.25.13

How to set up and validate locally

(guess what, we have exactly this case as a placeholder for this section!)

  1. Enable the invite modal
    Feature.enable(:overage_members_modal)
  2. Visit any group page that has a subscription OR create a new group and buy a premium subscription for one user for it.
  3. Click the invite members button
  4. If the added user will be over the subscription paid amount, the modal will be shown.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Diana Zubova

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ammar Alakkad removed review request for @aalakkad

    removed review request for @aalakkad

  • Diana Zubova added 1 commit

    added 1 commit

    Compare with previous version

  • Diana Zubova added 1 commit

    added 1 commit

    Compare with previous version

  • Diana Zubova requested review from @aalakkad

    requested review from @aalakkad

  • Diana Zubova added 1 commit

    added 1 commit

    Compare with previous version

  • Diana Zubova added 1 commit

    added 1 commit

    Compare with previous version

  • Diana Zubova added 1 commit

    added 1 commit

    Compare with previous version

  • Emily Sybrant approved this merge request

    approved this merge request

  • Emily Sybrant removed review request for @esybrant

    removed review request for @esybrant

  • :wave: @esybrant, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading