Allow (un)following someone in the user popover
What does this MR do and why?
This MR is a suggestion to make it possible for users to follow and unfollow users via the user popover on notes, issues, and more. This makes it easier to follow people and reduces the friction of having to go to the user's profile. It also allows you to quickly determine whether you are following someone.
The (un)follow actions are optimistically atomic and will change instantly after the user clicks on the button. If an error occurs, the button is changed back.
Inspired by #346623 and Twitter's user popover.
Screenshots or screen recordings
Before | Follow | Unfollow | Signed out or same user |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
- Enable the feature flag (rollout issue) using the Rails console:
bin/rails c
Feature.enable(:follow_in_user_popover)
- Go to an issue that you didn't create
- Hover over the user name of the user who created the issue
- See the follow/unfollow button
- When you click it: see that it changes state and the user is
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
/closes #353362 (closed)
Merge request reports
Activity
Thank you for your contribution to GitLab. We believe that everyone can contribute and contributions like yours are what make GitLab great!
- Our Merge Request Coaches will ensure your contribution is reviewed in a timely manner*.
- If you haven't, please set up a
DANGER_GITLAB_API_TOKEN
. - You can comment
@gitlab-bot label ~"group::"
to add a group label. - After a few days, feel free to ask
@gitlab-bot help
or ping a Merge Request Coach. - Read more on how to get help.
This message was generated automatically. You're welcome to improve it.
added Community contribution label
added Hackathon label
added UX label
- Resolved by Matej Latin
Thanks for this contribution @KevSlashNull!
I suggest a designer from devopsmanage reviews this. @badnewsblair can you suggest someone?
added devopsplan sectiondev labels
added devopsmanage groupauthentication and authorization [DEPRECATED] labels and removed devopsplan label
mentioned in issue KevSlashNull/KevSlashNull#3 (closed)
requested review from @matejlatin
mentioned in issue gitlab-org/quality/triage-reports#5565 (closed)
added 847 commits
-
940e3328...9618f99c - 846 commits from branch
gitlab-org:master
- 76f76b57 - Allow (un)following someone in the user popup
-
940e3328...9618f99c - 846 commits from branch
added 719 commits
-
76f76b57...4831b598 - 718 commits from branch
gitlab-org:master
- 43d37b9b - Allow (un)following someone in the user popup
-
76f76b57...4831b598 - 718 commits from branch
added 379 commits
-
43d37b9b...02917968 - 377 commits from branch
gitlab-org:master
- 12e25752 - Allow (un)following someone in the user popup
- 1383483a - Add test for follow button
-
43d37b9b...02917968 - 377 commits from branch
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
added 1 commit
- 0dc37f4f - Prevent follow actions change the popover width
- Resolved by Kushal Pandya
@matejlatin
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, please start a new pipeline before merging.
For more info, please refer to the following links:
- Resolved by Kushal Pandya
@peterhegman, could you do the frontend review for this MR if you have time, please?
changed milestone to %14.7
added featureaddition label
added typefeature label
assigned to @KevSlashNull
requested review from @peterhegman
added 3224 commits
-
0dc37f4f...f8040dc5 - 3218 commits from branch
gitlab-org:master
- 44ba6e57 - Allow (un)following someone in the user popup
- 12bcd618 - Add test for follow button
- 4cb7f953 - Prevent follow actions change the popover width
- 18cd8af6 - Add changes from code review
- 2b576799 - Fix layout overflows
- 260166c2 - Update specs to match component changes
Toggle commit list-
0dc37f4f...f8040dc5 - 3218 commits from branch
- Resolved by Kushal Pandya
- Resolved by Kev
- Resolved by Peter Hegman
- Resolved by Peter Hegman
- Resolved by Peter Hegman
- Resolved by Kev
- Resolved by Kev
- Resolved by Kev
- Resolved by Kev
requested review from @marc_shaw
changed milestone to %14.8
added 1 commit
- 9669b2b1 - Use single quote instead of typesetter apostroph
added 442 commits
-
86dd6815...26180cf7 - 431 commits from branch
gitlab-org:master
- d22f0c35 - Allow (un)following someone in the user popup
- 845aa316 - Add test for follow button
- 3b354064 - Prevent follow actions change the popover width
- 0163fcc8 - Add changes from code review
- 2cb97328 - Fix layout overflows
- 78d071bc - Update specs to match component changes
- 00341dba - Add error messages to locale file
- 0020f9f2 - Use findByTestId helper
- b86b2824 - Use single quote instead of typesetter apostroph
- ef8b2be7 - Fix typo in test message
- 364a6176 - Remove duplicate code
Toggle commit list-
86dd6815...26180cf7 - 431 commits from branch
added 1 commit
- edb43907 - Hide follow button when API doesn’t support following
added release post itemsecondary label
removed release post itemsecondary label
- Resolved by Hannah Sutor
Based on ~"group::workspace" owning User Profile, I think that this may be ~"group::workspace" instead of ~"group::authentication and authorization" . Thoughts @ogolowinski ?
added Category:User Management + 1 deleted label and removed groupauthentication and authorization [DEPRECATED] label
- Resolved by Kev
- Resolved by Kev
- Resolved by Kev
added 1796 commits
-
edb43907...3cb78825 - 1780 commits from branch
gitlab-org:master
- e303274a - Allow (un)following someone in the user popup
- 89897a70 - Add test for follow button
- 299fa32b - Prevent follow actions change the popover width
- dbabcce8 - Add changes from code review
- e4b956fb - Fix layout overflows
- 82644474 - Update specs to match component changes
- 4a041cb4 - Add error messages to locale file
- d59afc82 - Use findByTestId helper
- 742e2daa - Use single quote instead of typesetter apostroph
- 5d85586e - Fix typo in test message
- 0f53864b - Remove duplicate code
- 2784b929 - Hide follow button when API doesn’t support following
- dee51942 - Add negated test case for is_followed
- bea3b942 - Add missing tests for following and follower count
- dccee8b0 - Add test for is_followed field on logged-out users
- 0465b254 - Add test for un-/following event handlers
Toggle commit list-
edb43907...3cb78825 - 1780 commits from branch
- Resolved by Kushal Pandya
Hi @eread, please review this documentation Merge Request.
added documentation twtriaged labels
- Resolved by Marc Shaw
- Resolved by Marc Shaw
- Resolved by Kushal Pandya
Thanks @KevSlashNull!! This looks good to me !
mentioned in issue gitlab-com/www-gitlab-com#9408 (closed)
- Resolved by Matthias Käppler
requested review from @fneill
- Resolved by Matthias Käppler
- Resolved by Matthias Käppler
- Resolved by Matthias Käppler
added Technical Writing label
- Resolved by Kev
- Resolved by Evan Read
removed review request for @fneill
removed review request for @marc_shaw
added 2069 commits
-
69f2f210...56d571f9 - 2051 commits from branch
gitlab-org:master
- dfd9b173 - Allow (un)following someone in the user popup
- 90d40057 - Add test for follow button
- 93bca67c - Prevent follow actions change the popover width
- 17a8db69 - Add changes from code review
- 499574bd - Fix layout overflows
- 51ba4055 - Update specs to match component changes
- 573226bb - Add error messages to locale file
- 84a496d3 - Use findByTestId helper
- 4a5d86d2 - Use single quote instead of typesetter apostroph
- 482a88e9 - Fix typo in test message
- 4720d89b - Remove duplicate code
- d7215648 - Hide follow button when API doesn’t support following
- a099293e - Add negated test case for is_followed
- dd1f482f - Add missing tests for following and follower count
- 58098d7a - Add test for is_followed field on logged-out users
- 9435e6ec - Add test for un-/following event handlers
- 934107e6 - Add is_followed to users API docs
- 4998653a - Use contain_exactly for exposed attribute
Toggle commit list-
69f2f210...56d571f9 - 2051 commits from branch
mentioned in issue #353362 (closed)
changed milestone to %14.9
added 1212 commits
-
957ddb76...cffb21e8 - 1193 commits from branch
gitlab-org:master
- 75a97dbd - Allow (un)following someone in the user popup
- 1799094f - Add test for follow button
- a09fc0db - Prevent follow actions change the popover width
- 43a602c7 - Add changes from code review
- d8af888d - Fix layout overflows
- 799cdd98 - Update specs to match component changes
- 70062ff7 - Add error messages to locale file
- b4f2b68b - Use findByTestId helper
- dc39c9dc - Use single quote instead of typesetter apostroph
- 045983fd - Fix typo in test message
- 9fdc705f - Remove duplicate code
- 0c55013c - Hide follow button when API doesn’t support following
- 572f6a7a - Add negated test case for is_followed
- 7c21d60b - Add missing tests for following and follower count
- f77914bf - Add test for is_followed field on logged-out users
- 7d04feb8 - Add test for un-/following event handlers
- 6822c691 - Add is_followed to users API docs
- 47957585 - Use contain_exactly for exposed attribute
- 9da56d35 - Update UI text for follow errors
Toggle commit list-
957ddb76...cffb21e8 - 1193 commits from branch
- Resolved by Kushal Pandya
@peterhegman it looks like @matejlatin has approved this. Can you take a look and see if this can be merged?
added 1221 commits
-
9da56d35...35f1dd93 - 1220 commits from branch
gitlab-org:master
- b5576a06 - Allow (un)following someone in the user popover
-
9da56d35...35f1dd93 - 1220 commits from branch
mentioned in issue #354929
added 226 commits
-
b5ed364b...9d638a97 - 224 commits from branch
gitlab-org:master
- 9f875da6 - Allow (un)following someone in the user popover
- 9a219b97 - Add follow_in_user_popover feature flag
-
b5ed364b...9d638a97 - 224 commits from branch
- Resolved by Kev
mentioned in merge request gitlab-com/www-gitlab-com!99313 (merged)
- Resolved by Kushal Pandya
added 232 commits
-
9a219b97...d959694a - 230 commits from branch
gitlab-org:master
- d48c153a - Allow (un)following someone in the user popover
- cd3294c9 - Add follow_in_user_popover feature flag
-
9a219b97...d959694a - 230 commits from branch
added 1 commit
- a120d4d7 - Use current_user as actor for follow_in_user_popover flag
added 633 commits
-
a120d4d7...74e520c6 - 630 commits from branch
gitlab-org:master
- 5e0e6771 - Allow (un)following someone in the user popover
- b729ad4a - Add follow_in_user_popover feature flag
- a6baef58 - Use current_user as actor for follow_in_user_popover flag
Toggle commit list-
a120d4d7...74e520c6 - 630 commits from branch
3 Warnings b729ad4a: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. This merge request changed files with disabled eslint rules. Please consider fixing them. This merge request changed undocumented Vue components in
vue_shared/
. Please consider creating Stories for these components:app/assets/javascripts/vue_shared/components/user_popover/user_popover.vue
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. If needed, you can retry the
danger-review
job that generated this comment.Documentation review
The following files require a review from a technical writer:
doc/api/users.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Disabled eslint rules
The following files have disabled
eslint
rules. Please consider fixing them:app/assets/javascripts/user_popovers.js
Run the following command for more details
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \ 'app/assets/javascripts/user_popovers.js'
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Eugie Limpin ( @eugielimpin
) (UTC+8)Stan Hu ( @stanhu
) (UTC-7)frontend Mireya Andres ( @mgandres
) (UTC+8)Kushal Pandya ( @kushalpandya
) (UTC+5.5)UX Veethika Mishra ( @v_mishra
) (UTC+0)No maintainer available To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Danger- Resolved by Peter Hegman
requested review from @kushalpandya and removed review request for @peterhegman
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 81811623 and a6baef58
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent mainChunk 2.31 MB 2.31 MB +3.21 KB 0.1 % average 3.69 MB 3.69 MB - 0.0 % Significant Growth: 3Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.environments.index 1.12 MB 1.34 MB +231.05 KB 20.2 % pages.groups.group_members 536.69 KB 650.31 KB +113.62 KB 21.2 % pages.projects.project_members 1.29 MB 1.34 MB +56.26 KB 4.3 % Significant Reduction: 3Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.admin.audit_logs 1.01 MB 341.65 KB -690.57 KB -66.9 % pages.groups.audit_events 1.01 MB 345.97 KB -690.57 KB -66.6 % pages.projects.audit_events 1.18 MB 1.1 MB -82.8 KB -6.9 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@dmishunov
,@justin_ho
,@mikegreiling
or@nmezzopera
) for review, if you are unsure about the size increase.Note: We do not have exact data for 81811623. So we have used data from: 74b0b68e.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!review-qa-smoke:
test report
review-qa-reliable: test report
review-qa-blocking: test reportreview-qa-blocking:
test report for c8dbada3expand test summary
+-------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+--------+ | | passed | failed | skipped | flaky | result | +----------------------+--------+--------+---------+-------+--------+ | Create | 17 | 0 | 2 | 1 | ❗ | | Package | 0 | 0 | 1 | 0 | ➖ | | Plan | 41 | 0 | 1 | 1 | ❗ | | Verify | 12 | 0 | 1 | 7 | ❗ | | Manage | 28 | 0 | 2 | 10 | ❗ | | Protect | 2 | 0 | 0 | 0 | ✅ | | Version sanity check | 0 | 0 | 1 | 0 | ➖ | | Configure | 0 | 0 | 1 | 0 | ➖ | +----------------------+--------+--------+---------+-------+--------+ | Total | 100 | 0 | 9 | 19 | ❗ | +----------------------+--------+--------+---------+-------+--------+
- Resolved by Peter Hegman
- Resolved by Peter Hegman
- Resolved by Kushal Pandya
- Resolved by Kushal Pandya
Thanks for working on this feature @KevSlashNull! I've added some suggestions.
removed review request for @kushalpandya
added 787 commits
-
a6baef58...11c4a0bd - 784 commits from branch
gitlab-org:master
- 93471774 - Allow (un)following someone in the user popover
- f364d2e5 - Add follow_in_user_popover feature flag
- 9368dbe8 - Use current_user as actor for follow_in_user_popover flag
Toggle commit list-
a6baef58...11c4a0bd - 784 commits from branch
3 Warnings 02f8bfac: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. This merge request changed files with disabled eslint rules. Please consider fixing them. This merge request changed undocumented Vue components in
vue_shared/
. Please consider creating Stories for these components:app/assets/javascripts/vue_shared/components/user_popover/user_popover.vue
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. If needed, you can retry the
danger-review
job that generated this comment.Documentation review
The following files require a review from a technical writer:
doc/api/users.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Disabled eslint rules
The following files have disabled
eslint
rules. Please consider fixing them:app/assets/javascripts/user_popovers.js
Run the following command for more details
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \ 'app/assets/javascripts/user_popovers.js'
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Drew Blessing ( @dblessing
) (UTC-5)Stan Hu ( @stanhu
) (UTC-7)frontend Mireya Andres ( @mgandres
) (UTC+8)Jacques Erasmus ( @jerasmus
) (UTC+1)UX Veethika Mishra ( @v_mishra
) (UTC+0)No maintainer available To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Dangerchanged milestone to %14.10
added workflowin review label
assigned to @peterhegman
added 2897 commits
-
29a2089e...2bdc46c4 - 2891 commits from branch
gitlab-org:master
- b0421220 - Allow (un)following someone in the user popover
- 8eb18ff0 - Add follow_in_user_popover feature flag
- b6070d61 - Use current_user as actor for follow_in_user_popover flag
- d3e0eee0 - Add missing unfollow event listener after rebase
- 99aa3191 - Update spec for toggle follow button
- 70ec47e9 - Add specs for API methods
Toggle commit list-
29a2089e...2bdc46c4 - 2891 commits from branch
3 Warnings 517d5002: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. This merge request changed files with disabled eslint rules. Please consider fixing them. This merge request changed undocumented Vue components in
vue_shared/
. Please consider creating Stories for these components:app/assets/javascripts/vue_shared/components/user_popover/user_popover.vue
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. If needed, you can retry the
danger-review
job that generated this comment.Documentation review
The following files require a review from a technical writer:
doc/api/users.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Disabled eslint rules
The following files have disabled
eslint
rules. Please consider fixing them:app/assets/javascripts/user_popovers.js
Run the following command for more details
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \ 'app/assets/javascripts/user_popovers.js'
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Allen Cook ( @acook.gitlab
) (UTC-4)Terri Chu ( @terrichu
) (UTC-4)frontend Miranda Fluharty ( @mfluharty
) (UTC+1)Jose Ivan Vargas ( @jivanvl
) (UTC+0)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 4c7b583b and c8dbada3
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.45 MB 3.46 MB +3.98 KB 0.1 % mainChunk 1.93 MB 1.93 MB +3.9 KB 0.2 % Significant Growth: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.threat_monitoring.show 1.66 MB 1.75 MB +90.1 KB 5.3 % Significant Reduction: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.quality.test_cases.new 1.68 MB 1.65 MB -34.67 KB -2.0 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@dmishunov
,@justin_ho
,@mikegreiling
or@nmezzopera
) for review, if you are unsure about the size increase.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 321 commits
-
70ec47e9...2a0657dd - 317 commits from branch
gitlab-org:master
- 6badfebd - Allow (un)following someone in the user popover
- e5aacbe9 - Add follow_in_user_popover feature flag
- a985e0e7 - Use current_user as actor for follow_in_user_popover flag
- 2690592d - Address frontend maintainer feedback
Toggle commit list-
70ec47e9...2a0657dd - 317 commits from branch
- Resolved by Peter Hegman
requested review from @kushalpandya
- Resolved by Kushal Pandya
- Resolved by Peter Hegman
- Resolved by Kushal Pandya
removed review request for @kushalpandya
mentioned in issue #360960 (closed)
added 1894 commits
-
2690592d...b201bf83 - 1889 commits from branch
gitlab-org:master
- 618cb72f - Allow (un)following someone in the user popover
- 90c52c5a - Add follow_in_user_popover feature flag
- 28dca08f - Use current_user as actor for follow_in_user_popover flag
- 22b91766 - Address frontend maintainer feedback
- d1f77e4d - Update spec per reviewer feedback
Toggle commit list-
2690592d...b201bf83 - 1889 commits from branch
Suggested Reviewers (beta)
This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".
The individuals below may be good candidates to participate in the review based on various factors.
After you review all recommendations, please assign reviewers manually, as this is not done automatically.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Reviewers @mikolaj_wawrzyniak
,@mayra-cabrera
,@rkadam3
,@agarciatesares
,@dskim_gitlab
If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot
added 120 commits
-
d1f77e4d...3b77edea - 115 commits from branch
gitlab-org:master
- 73dc5eb2 - Allow (un)following someone in the user popover
- 8622cfd7 - Add follow_in_user_popover feature flag
- e79b82a7 - Use current_user as actor for follow_in_user_popover flag
- f517aac7 - Address frontend maintainer feedback
- 3e974ca0 - Update spec per reviewer feedback
Toggle commit list-
d1f77e4d...3b77edea - 115 commits from branch
added 1 commit
- 8a39a2ba - Fix rebase error that is causing failing pipelines
added 282 commits
-
8a39a2ba...0657e010 - 276 commits from branch
gitlab-org:master
- 6aeb791f - Allow (un)following someone in the user popover
- 517d5002 - Add follow_in_user_popover feature flag
- d23bc4e4 - Use current_user as actor for follow_in_user_popover flag
- 3f6362f7 - Address frontend maintainer feedback
- 0ff0b381 - Update spec per reviewer feedback
- c8dbada3 - Fix rebase error that is causing failing pipelines
Toggle commit list-
8a39a2ba...0657e010 - 276 commits from branch
requested review from @kushalpandya
removed review request for @kushalpandya
requested review from @kushalpandya
enabled an automatic merge when the pipeline for 3640aa7a succeeds
- Resolved by Kev
@KevSlashNull, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:
- Leave a
or a on this comment to describe your experience. - Create a new comment starting with
@gitlab-bot feedback
below, and leave any additional feedback you have for us in the comment.
Have five minutes? Take our survey to give us even more feedback on how GitLab can improve the contributor experience.
Thanks for your help!
- Leave a
mentioned in commit 629a61ce
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in merge request !86189 (merged)
mentioned in merge request !87159 (merged)
added releasedcandidate label
mentioned in merge request gitlab-com/www-gitlab-com!103567 (merged)
mentioned in merge request !88101 (merged)
- Resolved by Evan Read
@peterhegman, thank you a lot for taking over and also rolling out the feature flag!
mentioned in merge request kubitus-project/kubitus-installer!1040 (merged)
added docsfeature label
added devopsdata stores grouptenant scale sectioncore platform labels and removed devopsmanage sectiondev + 1 deleted label