Skip to content

Allow (un)following someone in the user popover

Kev requested to merge KevSlashNull/gitlab:Allow-un-following-through-the-user-popup into master

What does this MR do and why?

This MR is a suggestion to make it possible for users to follow and unfollow users via the user popover on notes, issues, and more. This makes it easier to follow people and reduces the friction of having to go to the user's profile. It also allows you to quickly determine whether you are following someone.

The (un)follow actions are optimistically atomic and will change instantly after the user clicks on the button. If an error occurs, the button is changed back.

Inspired by #346623 and Twitter's user popover.

Screenshots or screen recordings

Before Follow Unfollow Signed out or same user
image image image image

How to set up and validate locally

  1. Enable the feature flag (rollout issue) using the Rails console: bin/rails c 
    Feature.enable(:follow_in_user_popover)
  2. Go to an issue that you didn't create
  3. Hover over the user name of the user who created the issue
  4. See the follow/unfollow button
  5. When you click it: see that it changes state and the user is

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

 /closes #353362 (closed)

Edited by Kev

Merge request reports