Sync requirement and requirement issues state
What does this MR do and why?
This is part of state IIB of migrating requirements to work items(issues of type requirement).
Syncs state between issues(of type requirement) and requirements from both ends. Also makes sure no desync happens and if it happens logs an error.
- On
UpdateRequirementService
it uses a pseudo transaction to avoid desync already implemented on !64929 (merged) -
Issues::UpdateService
andIssues::CloseService
it uses a regular ActiveRecord transaction to avoid desync
related to #337190 (closed)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @felipe_artur
- A deleted user
added backend label
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Drew Cimino ( @drew
) (UTC-4, 1 hour behind@felipe_artur
)Dmitriy 'DZ' Zaporozhets ( @dzaporozhets
) (UTC+3, 6 hours ahead of@felipe_artur
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 1 commit
- fb86b258 - Sync requirement and requirement issues state
added 1 commit
- 558e0335 - Sync requirement and requirement issues state
added 149 commits
-
558e0335...4c768b1b - 148 commits from branch
master
- f416fad1 - Sync requirement and requirement issues state
-
558e0335...4c768b1b - 148 commits from branch
added 1 commit
- cec1c098 - Sync requirement and requirement issues state
Setting label groupproduct planning based on
@felipe_artur
's group.added groupproduct planning label
Setting label(s) devopsplan sectiondev based on groupproduct planning.
added devopsplan sectiondev labels
added 1 commit
- 1ba573e3 - Sync requirement and requirement issues state
added 1 commit
- 4a6c12a3 - Sync requirement and requirement issues state
added 1 commit
- 3c025253 - Sync requirement and requirement issues state
added 1 commit
- aebc5aee - Sync requirement and requirement issues state
added 1 commit
- eebaadbc - Sync requirement and requirement issues state
mentioned in merge request !70995 (closed)
added 1 commit
- 0ebf7c0d - Sync requirement and requirement issues state
added 1 commit
- 347303d2 - Sync requirement and requirement issues state
mentioned in issue #323779 (closed)
added 1 commit
- c450a6fd - Sync requirement and requirement issues state
added GitLab Ultimate typemaintenance + 1 deleted label
added typefeature label
@cablett Can you do initial review of this one, please?
requested review from @cablett
- Resolved by Michael Kozono
- Resolved by Alexandru Croitor
- Resolved by Felipe Cardozo
- Resolved by Felipe Cardozo
- Resolved by Alexandru Croitor
added 1165 commits
-
c450a6fd...0335e0c4 - 1164 commits from branch
master
- 25906e00 - Sync requirement and requirement issues state
-
c450a6fd...0335e0c4 - 1164 commits from branch
added 1 commit
- 879b37a0 - Sync requirement and requirement issues state
added 1 commit
- 0dd33483 - Sync requirement and requirement issues state
- Resolved by Michael Kozono
@acroitor Can you review, please?
requested review from @acroitor
- Resolved by Alexandru Croitor
- Resolved by Felipe Cardozo
- Resolved by Alexandru Croitor
- Resolved by Felipe Cardozo
- Resolved by Alexandru Croitor
- Resolved by Alexandru Croitor
- Resolved by Alexandru Croitor
- Resolved by Felipe Cardozo
- Resolved by Felipe Cardozo
removed review request for @acroitor
added 1 commit
- e3583994 - Sync requirement and requirement issues state