Sync update of title and description between RequirementsManagment::Requirement objects and requirement type issues
What does this MR do?
Now that !64291 (merged) is merged, we can move to syncing the updating of either requirement issues or their associated Requirements.
Part Stage IIb in #323779 (closed).
Syncs updates of Title and Description of Requirements and their associated requirement-type Issues. This happens regardless of the associated issue type of a Requirement.
There are several ways a requirement can be updated that should be reflected in the requirement-type issue to which it's associated:
- Toggled archived (closed) or open
- Title changed
- Description changed
- Project changed (read: moved) -> will be prohibited
This MR handles just handles sync of title and description. See #323779 (closed) for completion and context details.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #323779 (closed) and #337190 (closed)
Merge request reports
Activity
changed milestone to %14.1
assigned to @cablett
1 Message 
This merge request adds or changes files that require a review from the Database team. This merge request requires a database review. To make sure these changes are reviewed, take the following steps:
- Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
- Prepare your MR for database review according to the docs.
- Assign and mention the database reviewer suggested by Reviewer Roulette.
If you no longer require a database review, you can remove this suggestion by removing the database label and re-running the
danger-reviewjob.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Jackie Fraser ( @jackie_fraser) (UTC-4, 16 hours behind@cablett)Sean McGivern ( @smcgivern) (UTC+1, 11 hours behind@cablett)database Alishan 'Ali' Ladhani ( @ali-gitlab) (UTC-4, 16 hours behind@cablett)Patrick Bair ( @pbair) (UTC-4, 16 hours behind@cablett)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-reviewjob that generated this comment.Generated by
mentioned in issue #323779 (closed)
added 419 commits
-
a413eef2...2e8c3c07 - 418 commits from branch
323779-4-sync-requirements-and-issue-destruction - b7e48293 - Sync update between requirements and issues
-
a413eef2...2e8c3c07 - 418 commits from branch
Resolved by charlie ablettA suggestion was made by @felipe_artur to use DB triggers to sync these updates.
- Pros - simpler - no extra introduced business logic
- Cons - we miss out on things like system note creation, etc. These seem important.
Thoughts welcomed.
Edited by charlie ablett
added 2735 commits
-
3f092d57...eec90a86 - 2734 commits from branch
master - 8cb4eb08 - Sync update between requirements and issues
-
3f092d57...eec90a86 - 2734 commits from branch
changed milestone to %14.2
added 1821 commits
-
8cb4eb08...a8c5d692 - 1820 commits from branch
master - 5db1202b - Sync update between requirements and issues
-
8cb4eb08...a8c5d692 - 1820 commits from branch
- Resolved by Luke Duncalfe
- Last reply by Mikołaj Wawrzyniak
added workflowin review label and removed workflowin dev label
Resolved by charlie ablett
Please consider starting a new pipeline if:
- This is the first time the merge request is approved, or
- The merge request is ready to be merged, and there has not been a merge request pipeline in the last 2 hours.
For more info, refer to the guideline.
requested review from @mikolaj_wawrzyniak
requested review from @DylanGriffith
