Skip to content

[Geo] Add a worker to backfill verification state

Aakriti Gupta requested to merge ag-verifiables-update-worker into master

What does this MR do?

Closes #338597 (closed)

Things left to do

  • Extract BaseBatcher, MR here
  • Manually test out worker
  • Rebase this MR after BaseBatcher is merged, to remove those changes from this diff (Mike squashed the remaining code)
  • Do some TODO code comments (the commits were left separate for visibility)
  • Fix some static analysis failures (the commits were left separate for visibility)
  • Check handbook guide on adding new workers
  • Add more detailed logging
  • Add an FF to disable this worker until all work is complete, specially #338598 (closed)?
  • Add tests to VerificationStateBackfillWorker, similar to RegistryConsistencyWorker tests, to test for idempotency, job namespace
  • Remove list from Geo::VerifiablesUpdateWorker#replicable_classes, use replicators instead
  • Re-enqueue only when worker#execute does some work, like the RegistryConsistencyWorker
  • Add tests to show it reenqueues properly
  • Clean up MR

Screenshots or Screencasts (strongly suggested)

How to setup and validate locally (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Aakriti Gupta

Merge request reports