Skip to content

Refactor RegistryBatcher to make it reusable

Aakriti Gupta requested to merge ag-refactor-registry-worker into master

What does this MR do?

This MR is one of the pieces while working towards #338597 (closed).

It refactors Geo::RegistryBatcher to move most of the logic into Geo::BaseBatcher. BaseBatcher can be reused in the new VerifiablesUpdateWorker/VerifiablesUpdateService` that is being worked on in !69301 (merged)

The main changes are the following:

  • rename registry_class and model_class to destination_class and source_class, to make them more generic
  • move tests into shared examples
  • use these shared examples in registry_consistency_service_spec.

Screenshots or Screencasts (strongly suggested)

How to setup and validate locally (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Michael Kozono

Merge request reports