Skip to content

Make the credit card validation alert dismissible

Payton Burdette requested to merge 331154-dismiss-cc-validation into master

What does this MR do?

This MR makes the credit card validation alert dismissible until the next pipeline run (if there is another error). Also ensures the shared_runners_toggle component dismiss event will dismiss now since it uses the same component.

This change is guarded on the BE by the flag ci_require_credit_card_on_free_plan

Related to: #331154 (closed)

Screenshots or Screencasts (strongly suggested)

cc_alert_dismissible

shared_runners_alert

How to setup and validate locally (strongly suggested)

  • In ee/app/models/ee/user.rb change the requires_credit_card? method locally to return true for testing purposes.
  • Then attempt to run a pipeline, dismiss the alert and try to run the pipeline again (you should see the alert again)
  • Check that alert is not showing if there is no CC validation error

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #331154 (closed)

Edited by Payton Burdette

Merge request reports