Make the credit card validation alert dismissible

What does this MR do?

This MR makes the credit card validation alert dismissible until the next pipeline run (if there is another error). Also ensures the shared_runners_toggle component dismiss event will dismiss now since it uses the same component.

This change is guarded on the BE by the flag ci_require_credit_card_on_free_plan

Related to: #331154 (closed)

Screenshots or Screencasts (strongly suggested)

cc_alert_dismissible

shared_runners_alert

How to setup and validate locally (strongly suggested)

• In ee/app/models/ee/user.rb change the requires_credit_card? method locally to return true for testing purposes.
• Then attempt to run a pipeline, dismiss the alert and try to run the pipeline again (you should see the alert again)
• Check that alert is not showing if there is no CC validation error

Does this MR meet the acceptance criteria?

Conformity

• I have included changelog trailers, or none are needed. (Does this MR need a changelog?)
• I have added/updated documentation, or it's not needed. (Is documentation required?)
• I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?)
• I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
• I have self-reviewed this MR per code review guidelines.
• This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines)
• I have followed the style guides.
• This change is backwards compatible across updates, or this does not apply.

Availability and Testing

• I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.)
• I have tested this MR in all supported browsers, or it's not needed.
• I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

• Label as security and @ mention @gitlab-com/gl-security/appsec
• The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• Security reports checked/validated by a reviewer from the AppSec team

Related to #331154 (closed)

changed milestone to %14.3

added Category:Continuous Integration UX VerifyP2 [deprecated] Accepting merge requests devopsverify frontend grouppipeline execution sectionops workflowin dev labels

assigned to @pburdette

changed the description

	1 Warning
	Please add a merge request type to this merge request.

	1 Message
	CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog. If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message. If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
frontend	Fernando Arias (@farias-gl) (UTC+1, 5 hours ahead of @pburdette)	Illya Klymov (@xanf) (UTC+3, 7 hours ahead of @pburdette)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits e7144b5c and bebd27c3

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
mainChunk	1.87 MB	1.85 MB	-16.53 KB	-0.9 %
average	3.13 MB	3.13 MB	-6.17 KB	-0.2 %

Significant Growth: 28

Expand

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
pages.projects.boards	2.11 MB	2.9 MB	+810.46 KB	37.5 %
pages.groups.boards	2.1 MB	2.88 MB	+802.62 KB	37.3 %
pages.projects.merge_requests.index	717.37 KB	1.4 MB	+716.26 KB	99.8 %
pages.groups.merge_requests	385.63 KB	1.08 MB	+715.53 KB	185.5 %
pages.groups.epic_boards	1.93 MB	2.05 MB	+120.84 KB	6.1 %
pages.projects.issues.edit	1.32 MB	1.41 MB	+95.75 KB	7.1 %
pages.projects.issues.new	1.32 MB	1.41 MB	+95.75 KB	7.1 %
pages.projects.merge_requests.creations.diffs	2.22 MB	2.31 MB	+94.66 KB	4.2 %
pages.projects.merge_requests.edit	2.24 MB	2.33 MB	+94.66 KB	4.1 %
pages.projects.merge_requests.creations	1.21 MB	1.31 MB	+94.19 KB	7.6 %

The table above is limited to 10 entries. Please look at the full report for more details

Significant Reduction: 2

Expand

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
pages.subscriptions.buy_storage	867.56 KB	3.54 KB	-864.02 KB	-99.6 %
sentry	150.91 KB	143.14 KB	-7.77 KB	-5.2 %

---

Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.

Please consider pinging someone from the FE Foundations (@dmishunov, @justin_ho, @mikegreiling or @nmezzopera) for review, if you are unsure about the size increase.

Please look at the full report for more details

---

Read more about how this report works.

Generated by Danger

Allure report

allure-report-publisher generated test report for bebd27c3!

review-qa-smoke: test report

removed [deprecated] Accepting merge requests label

removed workflowin dev label

marked the checklist item I have included changelog trailers, or none are needed. (Does this MR need a changelog?) as completed

marked the checklist item I have added/updated documentation, or it's not needed. (Is documentation required?) as completed

marked the checklist item I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) as completed

marked the checklist item I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) as completed

marked the checklist item I have self-reviewed this MR per code review guidelines. as completed

marked the checklist item This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) as completed

marked the checklist item I have followed the style guides. as completed

marked the checklist item This change is backwards compatible across updates, or this does not apply. as completed

marked the checklist item I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) as completed

marked the checklist item I have tested this MR in all supported browsers, or it's not needed. as completed

marked the checklist item I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed. as completed

added 1 commit

• bebd27c3 - Make CC validation alert dismissible

Compare with previous version

changed the description

requested review from @v_mishra

Hey @v_mishra would you mind giving this MR a UX review for me?

@himkp can you do the first review for me?

requested review from @himkp

approved this merge request

removed review request for @himkp

@himkp, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

For more info, please refer to the following links:

• rspec minimal jobs
• merging a merge request.

approved this merge request

removed review request for @v_mishra

resolved all threads

mentioned in issue #339949 (closed)

@jerasmus would you mind doing the maintainer review here please?

requested review from @jerasmus

approved this merge request

enabled an automatic merge when the pipeline for 7d04274e succeeds

merged

mentioned in commit 887d1391

added workflowstaging label

added workflowcanary label and removed workflowstaging label

added workflowproduction label and removed workflowcanary label

added workflowstaging-canary label and removed workflowproduction label

added releasedcandidate label

added releasedpublished label and removed releasedcandidate label