Make the credit card validation alert dismissible
What does this MR do?
This MR makes the credit card validation alert dismissible until the next pipeline run (if there is another error). Also ensures the shared_runners_toggle
component dismiss event will dismiss now since it uses the same component.
This change is guarded on the BE by the flag ci_require_credit_card_on_free_plan
Related to: #331154 (closed)
Screenshots or Screencasts (strongly suggested)
How to setup and validate locally (strongly suggested)
- In
ee/app/models/ee/user.rb
change therequires_credit_card?
method locally to returntrue
for testing purposes. - Then attempt to run a pipeline, dismiss the alert and try to run the pipeline again (you should see the alert again)
- Check that alert is not showing if there is no CC validation error
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #331154 (closed)
Edited by Payton Burdette