Mark issues created by banned users as hidden (!63676) · Merge requests · GitLab.org / GitLab

What does this MR do?

Introduce hidden attribute for issues. When a user gets banned (introduced by !61292 (merged)), set that user's issues to hidden. This MR only sets issue.hidden? to true (or false when the author is unbanned), and does not actually prevent access to that issue or exclude it from open issues count. That functionality will be implemented in a follow-up MR: !63700 (closed) (WIP)

DB migration output:

% rails db:migrate
== 20210608211735 AddHiddenToIssues: migrating ================================
-- add_column(:issues, :hidden, :boolean, {:default=>false})
   -> 0.0044s
== 20210608211735 AddHiddenToIssues: migrated (0.0045s) =======================


% rails db:rollback STEP=1
== 20210608211735 AddHiddenToIssues: reverting ================================
-- remove_column(:issues, :hidden)
   -> 0.0053s
== 20210608211735 AddHiddenToIssues: reverted (0.0054s) =======================

In #database-lab:

explain UPDATE "issues" SET "hidden" = TRUE WHERE "issues"."author_id" = 5966677

https://postgres.ai/console/gitlab/gitlab-production-tunnel-pg12/sessions/4548/commands/16012

SELECT "issues"."id" FROM "issues" WHERE "issues"."author_id" = 1 ORDER BY "issues"."id" ASC LIMIT 1

https://console.postgres.ai/gitlab/gitlab-production-tunnel-pg12/sessions/4544/commands/15994

SELECT "issues"."id" FROM "issues" WHERE "issues"."author_id" = 1 AND "issues"."id" >= 965 ORDER BY "issues"."id" ASC LIMIT 1 OFFSET 100

https://console.postgres.ai/gitlab/gitlab-production-tunnel-pg12/sessions/4544/commands/15995

UPDATE "issues" SET "hidden" = TRUE WHERE "issues"."author_id" = 1 AND "issues"."id" >= 965 AND "issues"."id" < 22437

https://console.postgres.ai/gitlab/gitlab-production-tunnel-pg12/sessions/4544/commands/15996

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

I have included a changelog entry, or it's not needed. (Does this MR need a changelog?)
I have added/updated documentation, or it's not needed. (Is documentation required?)
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?)
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
I have self-reviewed this MR per code review guidelines.
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines)
I have followed the style guides.
This change is backwards compatible across updates, or this does not apply.

Availability and Testing

I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.)
I have tested this MR in all supported browsers, or it's not needed.
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

Label as security and @ mention @gitlab-com/gl-security/appsec
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
Security reports checked/validated by a reviewer from the AppSec team

Edited Jun 11, 2021 by Serena Fang

Mark issues created by banned users as hidden