Skip to content

Hide hidden issues from issues list

Serena Fang requested to merge hide-hidden-issues into master

What does this MR do?

Epic: &5741

Issue: #327355 (closed)

Malicious actors create many issues in public projects/groups for spam. We need a way to be able to hide their issues until they can be reviewed and deemed safe. So we've introduced the ability for admins to ban users, which blocks the user and hides their contributions.

This MR hides issues created by banned users from non-admins. Admin users can still see the hidden issues so they can review the issues' contents.

Follow up issues for UI polish: #332408 (closed), https://gitlab.com/gitlab-org/gitlab/-/issues/332409

Remember to rebase after !63676 (closed)

Screenshots (strongly suggested)

When admin:

Project open issue count includes confidential and hidden issues. Hidden issues are indicated by a spam icon and with a tooltip that lets the admin know why the issue is hidden. Admin can access hidden issues to review their content.

image

Group issue count includes confidential and hidden issues.

image

When group reporter:

Project open issue count includes confidential issues but not hidden issues. Hidden issue does not appear in issues list, and reporter cannot access hidden issue even when following a link.

image

Group issue count includes confidential issues but not hidden issues.

image

When non-member:

Project open issue count does not include confidential or hidden issues. Hidden issue does not appear in issues list, and non-member cannot access hidden issue even when following a link.

image

Group issue count does not include confidential or hidden issues.

image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Serena Fang

Merge request reports